Quasar chain uprgade #607
Merged
Quasar chain uprgade #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 1. Overview - `genutil` module was not initalised with `DefaultMessageValidator` - added a simple test script in `/scripts` <!-- What are you changing, removing, or adding in this review? --> ## 2. Implementation details <!-- Describe the implementation (highlights only) as well as design rationale. --> ## 3. How to test/use <!-- How can people test/use this? --> ## 4. Checklist <!-- Checklist for PR author(s). --> - [ ] Does the Readme need to be updated? ## 5. Limitations (optional) <!-- Describe any limitation of the capabilities listed in the Overview section. --> ## 6. Future Work (optional) <!-- Describe follow up work, if any. --> Co-authored-by: Ajaz Ahmed <ajansari95@Ajazs-MacBook-Pro.local>
# Conflicts: # app/app.go # go.mod # go.sum # tests/e2e/cases/osmosis_gauge/osmosis_gauge_test.go
akure
reviewed
Jul 4, 2024
akure
reviewed
Jul 4, 2024
ajansari95
requested changes
Jul 11, 2024
There was a problem hiding this comment.
A thorough cleanup of the PR is required. Points that need to be addressed include:
- A lot of commented code.
- Inconsistent import grouping.
- TODOs , if addressed, should be removed. Additionally, we have at numerous placesmentioned we need to recheck if the fix works was it rechecked?if yes the comment should be removed.
I believe our CI is very weak; this PR shouldn't have passed any lint checks. We need to specify strict linting rules.
demos/upgrade-handler/v2.0.0/go-relayer-config/chains/osmosis.json
Outdated
Show resolved
Hide resolved
magiodev
reviewed
Jul 15, 2024
magiodev
previously approved these changes
Jul 16, 2024
ajansari95
previously approved these changes
Jul 16, 2024
arhamchordia
dismissed stale reviews from akure, ajansari95, and magiodev
via
4ed0b31
ajansari95
approved these changes
Jul 22, 2024
magiodev
approved these changes
Jul 22, 2024
akure
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Overview
Chain upgrade from sdk45 to sdk47
2. Implementation details
Changes made in this PR are mostly on adding few new modules into play and upgrading versions of old dependencies :
3. How to test/use
Testing can be done by running :
quasarnodedv1demos/upgrade-handler/v2.0.0Upgrade test will run the old binary with relayer setup and some IBC connections to Osmosis chain.
And then it will perform some pre upgrade transactions and then post the upgrade proposal.
Once the desired block height is reached then the setup will automatically stop the old chain and start with new binary.
New binary once started, it will be tested using the post_upgrade actions on chain.
4. Checklist
5. Limitations (optional)
6. Future Work (optional)