-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quasar chain uprgade #607
Quasar chain uprgade #607
Conversation
## 1. Overview - `genutil` module was not initalised with `DefaultMessageValidator` - added a simple test script in `/scripts` <!-- What are you changing, removing, or adding in this review? --> ## 2. Implementation details <!-- Describe the implementation (highlights only) as well as design rationale. --> ## 3. How to test/use <!-- How can people test/use this? --> ## 4. Checklist <!-- Checklist for PR author(s). --> - [ ] Does the Readme need to be updated? ## 5. Limitations (optional) <!-- Describe any limitation of the capabilities listed in the Overview section. --> ## 6. Future Work (optional) <!-- Describe follow up work, if any. --> Co-authored-by: Ajaz Ahmed <ajansari95@Ajazs-MacBook-Pro.local>
# Conflicts: # app/app.go # go.mod # go.sum # tests/e2e/cases/osmosis_gauge/osmosis_gauge_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thorough cleanup of the PR is required. Points that need to be addressed include:
- A lot of commented code.
- Inconsistent import grouping.
- TODOs , if addressed, should be removed. Additionally, we have at numerous placesmentioned we need to recheck if the fix works was it rechecked?if yes the comment should be removed.
I believe our CI is very weak; this PR shouldn't have passed any lint checks. We need to specify strict linting rules.
demos/upgrade-handler/v2.0.0/go-relayer-config/chains/osmosis.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
4ed0b31
1. Overview
Chain upgrade from sdk45 to sdk47
2. Implementation details
Changes made in this PR are mostly on adding few new modules into play and upgrading versions of old dependencies :
3. How to test/use
Testing can be done by running :
quasarnodedv1
demos/upgrade-handler/v2.0.0
Upgrade test will run the old binary with relayer setup and some IBC connections to Osmosis chain.
And then it will perform some pre upgrade transactions and then post the upgrade proposal.
Once the desired block height is reached then the setup will automatically stop the old chain and start with new binary.
New binary once started, it will be tested using the post_upgrade actions on chain.
4. Checklist
5. Limitations (optional)
6. Future Work (optional)