Skip to content

Commit

Permalink
fix(app): Regression on resolving assets with ~ symbol #5701
Browse files Browse the repository at this point in the history
  • Loading branch information
rstoenescu committed Nov 27, 2019
1 parent 884f5ed commit 66fbbcf
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 21 deletions.
3 changes: 3 additions & 0 deletions app/lib/webpack/create-chain.js
Expand Up @@ -152,6 +152,7 @@ module.exports = function (cfg, configName) {
.use('url-loader')
.loader('url-loader')
.options({
esModule: false,
limit: 10000,
name: `img/[name]${fileHash}.[ext]`
})
Expand All @@ -161,6 +162,7 @@ module.exports = function (cfg, configName) {
.use('url-loader')
.loader('url-loader')
.options({
esModule: false,
limit: 10000,
name: `fonts/[name]${fileHash}.[ext]`
})
Expand All @@ -170,6 +172,7 @@ module.exports = function (cfg, configName) {
.use('url-loader')
.loader('url-loader')
.options({
esModule: false,
limit: 10000,
name: `media/[name]${fileHash}.[ext]`
})
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
Expand Up @@ -55,7 +55,7 @@
"elementtree": "0.1.7",
"express": "4.17.1",
"fast-glob": "3.1.0",
"file-loader": "4.2.0",
"file-loader": "^5.0.2",
"friendly-errors-webpack-plugin": "1.7.0",
"fs-extra": "8.1.0",
"hash-sum": "2.0.0",
Expand Down
40 changes: 20 additions & 20 deletions app/yarn.lock
Expand Up @@ -1104,9 +1104,9 @@ acorn-walk@^6.1.1:
integrity sha512-7evsyfH1cLOCdAzZAd43Cic04yKydNx0cF+7tiA19p1XnLLPU4dpCQOqpjqwokFe//vS0QqfqqjCS2JkiIs0cA==

acorn@^6.0.7, acorn@^6.2.1:
version "6.3.0"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.3.0.tgz#0087509119ffa4fc0a0041d1e93a417e68cb856e"
integrity sha512-/czfa8BwS88b9gWQVhc8eknunSA2DoJpJyTQkhheIf5E48u1N0R4q/YxxsAeqRrmK9TQ/uYfgLDfZo91UlANIA==
version "6.4.0"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.4.0.tgz#b659d2ffbafa24baf5db1cdbb2c94a983ecd2784"
integrity sha512-gac8OEcQ2Li1dxIEWGZzsp2BitJxwkwcOm0zHAJLcPJaVvm58FRnk6RkuLRpU1EujipU2ZFODv2P9DLMfnV8mw==

aggregate-error@^3.0.0:
version "3.0.1"
Expand Down Expand Up @@ -1376,9 +1376,9 @@ aws-sign2@~0.7.0:
integrity sha1-tG6JCTSpWR8tL2+G1+ap8bP+dqg=

aws4@^1.8.0:
version "1.8.0"
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f"
integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==
version "1.9.0"
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.9.0.tgz#24390e6ad61386b0a747265754d2a17219de862c"
integrity sha512-Uvq6hVe90D0B2WEnUqtdgY1bATGz3mw33nH9Y+dmA+w5DHvUmBgkr5rM/KCHpCsiFNRUfokW/szpPPgMK2hm4A==

babel-extract-comments@^1.0.0:
version "1.0.0"
Expand Down Expand Up @@ -2284,17 +2284,17 @@ copy-webpack-plugin@5.0.5:
webpack-log "^2.0.0"

core-js-compat@^3.1.1:
version "3.4.3"
resolved "https://registry.yarnpkg.com/core-js-compat/-/core-js-compat-3.4.3.tgz#54f2c5cd77b8b5acc5048904cc795722c9d590d1"
integrity sha512-HgW7pxjAdq6EMxT5uOhbTfjgZo8fvWn0D6QXVlWs3z1Eerux7tRrJ4gcgnZNn6S0OMPHlClJuIEPp0hnow44Sg==
version "3.4.4"
resolved "https://registry.yarnpkg.com/core-js-compat/-/core-js-compat-3.4.4.tgz#d0aa01b1d626e129455d51aa94c27127c564ba2b"
integrity sha512-hBbxJ6sOkaFSvwAXjJ/t/1usGIPK5gTbtqV8+T+u1pZBkgQ3lDQgAguN1g01PJ0b3eyQxgRIEgxqGoviE1QtIQ==
dependencies:
browserslist "^4.7.3"
semver "^6.3.0"

core-js-pure@^3.0.0:
version "3.4.3"
resolved "https://registry.yarnpkg.com/core-js-pure/-/core-js-pure-3.4.3.tgz#3966bd32036fb62ddeeeef7e4eeea7a2591adc4a"
integrity sha512-ENo6UqO6mkRdDa6VaHeLfu8B/e379CJMl6+qUNOjQNOtjHp14lIgAMoaGhCl3HOr48tuDVLJf1636s9ADDn/QA==
version "3.4.4"
resolved "https://registry.yarnpkg.com/core-js-pure/-/core-js-pure-3.4.4.tgz#613b936fa0c0482216f0c93794cd8139886efb53"
integrity sha512-9d1yvRrCdMmO/OtX6/QyEpB0qvUca5Tq7hskGpvuERakgGoG4/PWzwOH09ikpKDWeQ/W2FERSntz8r1x5t6PmA==

core-js@^2.4.0, core-js@^2.6.5:
version "2.6.10"
Expand Down Expand Up @@ -3237,13 +3237,13 @@ figures@^3.0.0:
dependencies:
escape-string-regexp "^1.0.5"

file-loader@4.2.0:
version "4.2.0"
resolved "https://registry.yarnpkg.com/file-loader/-/file-loader-4.2.0.tgz#5fb124d2369d7075d70a9a5abecd12e60a95215e"
integrity sha512-+xZnaK5R8kBJrHK0/6HRlrKNamvVS5rjyuju+rnyxRGuwUJwpAMsVzUl5dz6rK8brkzjV6JpcFNjp6NqV0g1OQ==
file-loader@^5.0.2:
version "5.0.2"
resolved "https://registry.yarnpkg.com/file-loader/-/file-loader-5.0.2.tgz#7f3d8b4ac85a5e8df61338cfec95d7405f971caa"
integrity sha512-QMiQ+WBkGLejKe81HU8SZ9PovsU/5uaLo0JdTCEXOYv7i7jfAjHZi1tcwp9tSASJPOmmHZtbdCervFmXMH/Dcg==
dependencies:
loader-utils "^1.2.3"
schema-utils "^2.0.0"
schema-utils "^2.5.0"

filesize@^3.6.1:
version "3.6.1"
Expand Down Expand Up @@ -6725,9 +6725,9 @@ resolve-url@^0.2.1:
integrity sha1-LGN/53yJOv0qZj/iGqkIAGjiBSo=

resolve@^1.10.0, resolve@^1.2.0, resolve@^1.3.2, resolve@^1.4.0, resolve@^1.8.1:
version "1.13.0"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.13.0.tgz#e879eb397efb40511056ede7300b6ac28c51290b"
integrity sha512-HHZ3hmOrk5SvybTb18xq4Ek2uLqLO5/goFCYUyvn26nWox4hdlKlfC/+dChIZ6qc4ZeYcN9ekTz0yyHsFgumMw==
version "1.13.1"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.13.1.tgz#be0aa4c06acd53083505abb35f4d66932ab35d16"
integrity sha512-CxqObCX8K8YtAhOBRg+lrcdn+LK+WYOS8tSjqSFbjtrI5PnS63QPhZl4+yKfrU9tdsbMu9Anr/amegT87M9Z6w==
dependencies:
path-parse "^1.0.6"

Expand Down

0 comments on commit 66fbbcf

Please sign in to comment.