Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QFooter and QHeader are always fixed when using containerized QLayout. #11397

Closed
2 of 14 tasks
Evertvdw opened this issue Nov 18, 2021 · 1 comment
Closed
2 of 14 tasks
Labels
Qv2 🔝 Quasar v2 issues

Comments

@Evertvdw
Copy link
Contributor

Describe the bug
When using a QLayout in containerized mode it is currently not possible to have the footer not 'fixed' at the bottom. I would like to have the footer be part of the page, so only visible when you have scrolled all the way down.

Only options currently are having it fixed or using the reveal proptery of the footer. The same thing applies to the header, there that option is also not available when using containerized layouts.

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/Mett-codepens/pen/GRvzyzL?editors=101

To Reproduce
Steps to reproduce the behavior:

  1. Notice the small 'f' in the layoutView. This normally indicates if you want your footer fixed or not.
  2. Scroll down and see that footer is always fixed.

Expected behavior
Footer (and header) should scroll in and out of view with the rest of the page content.

I created a PR to fix this issue: #11369

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):
Quasar Version: 2.3.2
@quasar/app Version:

Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Additional context

@Evertvdw Evertvdw added the Qv2 🔝 Quasar v2 issues label Nov 18, 2021
@rstoenescu
Copy link
Member

This is on purpose, but honestly I can't remember the reason.

This should be tested on a page with multiple QLayout view configurations (including "funky" ones like "lhh LpR ffr" but not limited to) and on:

  • Desktop Chrome / FF / Safari
  • Mobile browser Chrome / FF / Safari
  • Cordova app Android / iOS
  • Capacitor app Android / iOS
  • PWA (after installing it and launching it): iOS (especially), Android
  • Electron

Cannot merge the PR until these tests are done.

rstoenescu added a commit that referenced this issue Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants