-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility documentation #11889
Comments
To be honest I don't know what we should write there.
I cannot write a novel with the subject: we didn't break native TAB navigation |
Well, there's a lot more to web accessibility than that. I don't know that much about it myself either I'm afraid, but perhaps the A11Y Project could be of help here. As a start, I would recommend checking all components using the Lighthouse accessibility analysis tool. I found issues #11895 and #11894 because I happened to use those components on my page and scanned it with Lighthouse. But it would be great if all Quasar components go through a test by default. More generally speaking, I think it would be great if this topic were properly addressed in the documentation, showing this really is a matter of importance to the Quasar community. And, of course, I'll let you know whenever I find a concrete accessibility issue ❤️ |
Accessibility is a huge subject. And just to shatter a dream; no tool can ever be 100% accessible. (It's even more unattainable than being 100% bug-free.) This also means that people depending on accessibility, already know you're not going to be fully accessible. So a good place to start documenting, is to list which accessibility features Quasar aims to support. Some features can be expected to be build-in (such as keyboard navigation), while others will need to be implemented by developers using Quasar (such as landmarks). Some basic accessibility features you can start the list with:
And just as a quick note:
Yes, there are Quasar elements that do break tab navigation. |
@pdanpdan It's reasonable to assume that if nothing is said about accessibility then the framework doesn't make effort in supporting it (since so many frameworks don't). Hilariously to me PrimeNG states accessibility is a major concern but their dropdowns aren't read with a screen reader. Quasar seems to get it right without saying anything. However it's quite hard to convince teams or higher ups to adopt Quasar if accessibility is a frontline concern of theirs. In some countries it's legally required to provide an accessible UI, and/or some customers will specifically require it. With nothing in the docs to back it up it can't be considered as a framework of choice. Even just a few lines say "we're really focused on making our components accessible" goes a long way. I can see by searching Github tickets there's been some work on it, but I suspect a lot of people won't go that far in their investigation. |
I hate bullshit, so I'll not make a PR about "accessibility is very important for us". But I do agree we need:
Any help would be appreciated |
That comparison is done by verify and if you check they do everything and other frameworks do nothing. |
Sure, I know, but there should be some PR, or leave the PR, just some information on the a11y quasar do provide. For me as developer using Quasar, it helps by presenting the a11y support the framework deliver. By the way, i love Quasar!!! |
Let me share my answer to someone that asked about a11y on our Discord server last week:
Also, another thing about the chart there:
They are correct that we don't provide 18 Months LTS, because we provide more than that 🙂 ~46 months for Qv1, ~21 months for Qv2. Both of them, especially Qv2 will be potentially supported for even longer than planned. This version of the chart is the "corrected" version, the old version had tree-shaking as "manual", and contained more mistakes. So, in short, I wouldn't trust that chart too much, it's biased and contains false information, and can get outdated really quickly. So, anyways, we do care about a11y, and we've spent a good amount of effort to improve a11y support, mostly, if not entirely, thanks to @pdanpdan. We are trying to resolve a11y issues as they are reported. We can't say we are definitely 100% covered, we have no proof of that, but we are covered on a11y side as far as we and our users are aware. As @pdanpdan pointed out, we have to document which component gets which a11y treatment, whether the developers themselves should handle a specific treatment, etc. We should also have some automated tests that use a tool like axe so that we are constantly monitoring a11y. But, all these need time, effort, and knowledge, which we don't have enough of, unfortunately. So, if anyone is interested in this topic, please don't hesitate to provide more info, create a PR, etc. |
Sorry hate to break this one open again but with upcomming 2025 EAA might be good to take a look at this again. @yusufkandemir Would it make sense for us to tackle automated testing if we implemented Storybook? Most of storybook is very heavy on A11Y and with the upcomming 2025 EAA regulations I can only see this increase. It also has Axe built in https://storybook.js.org/addons/@storybook/addon-a11y so it might be a perfect fit. We will be diving into implementing storybook in our quasar project the next comming weeks and see what axe reports to us already |
I am hitting a lot of blockers with quasar with regard to accessibility.
-Quasar's carousel's control buttons don't have discernible text |
@HarisSpahija do you have any updates? Did you manage to integrate Storybook and test out Axe? |
You don't need a prop to do that, you can do it through attributes:
I guess you mean the non-numbered pagination items and also the next and previous buttons, yes that's correct. Unfortunately, it's not the only component that has this problem. But, please open a separate issue for this so we can track it in an easier way. This issue is about documenting a11y stuff, not reporting/fixing the faulty aspects. Thanks. |
The current documentation is very limited regarding the accessibility of Quasar. All it says is "Accessibility features" on the Why Quasar page.
Since the rest of the Quasar documentation is very extensive, even covering topics not directly related to Quasar, I was surprised to see this important topic being skipped. Vuetify does have an entire page dedicated to this topic.
I would love to see the following:
The text was updated successfully, but these errors were encountered: