Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom sheet action is missing property "id" #11924

Closed
4 of 20 tasks
suneab opened this issue Jan 6, 2022 · 4 comments
Closed
4 of 20 tasks

Bottom sheet action is missing property "id" #11924

suneab opened this issue Jan 6, 2022 · 4 comments
Labels
area/plugins area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@suneab
Copy link

suneab commented Jan 6, 2022

Describe the bug
The "id" property is missing on the actions type for Bottom Sheet. The API shows no "id" field under actions https://quasar.dev/api-explorer#api--bottomsheet

Codepen/jsFiddle/Codesandbox (required or your issue may be closed)
Everything works if you ignore the typescript warnings https://jsfiddle.net/pm4v0jg9/1/

To Reproduce
Steps to reproduce the behavior:
Copy paste the examples for how to use the component here: https://quasar.dev/quasar-plugins/bottom-sheet#usage
Implement in your IDE with any typescript validation

Expected behavior
No errors

Screenshots
image

Platform (please complete the following information):
Quasar Version:
@quasar/app Version: 2.4.3

Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX
  • Vite Plugin

Additonal Info:

  • Typescript
  • SFC usage with <script setup>
  • Vuex
  • Prettier (eslint)
  • Standard (eslint)

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

OS: OSX 12.0.1
Node: 16.13.0
NPM: 8.1
Yarn:
Browsers: Chrome
iOS:
Android:
Electron:

Additional context
This issue could have been posted in the incorrect docs folder, but i think this variable is very valuable as no other reliable identification for the selected answer is available

@pdanpdan
Copy link
Collaborator

pdanpdan commented Jan 6, 2022

Please change the title to request changes in TS definition to allow extra properties in actions objects
The id key is an extra property, so it is not specified in the definition

@yusufkandemir yusufkandemir added kind/bug 🐞 area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. Qv2 🔝 Quasar v2 issues area/plugins labels Jan 6, 2022
@rstoenescu
Copy link
Member

There's no need for the id prop.

@suneab
Copy link
Author

suneab commented Jan 7, 2022

Labels aren't necessarily unique. A unique identifier for each option would be valuable.

@rstoenescu
Copy link
Member

Will be available in Quasar v2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

4 participants