Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global LoadingBar component does not have isActive reactive prop. #12059

Closed
StefanoMantero opened this issue Jan 16, 2022 · 2 comments
Closed

Global LoadingBar component does not have isActive reactive prop. #12059

StefanoMantero opened this issue Jan 16, 2022 · 2 comments
Labels
area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/umd kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@StefanoMantero
Copy link
Contributor

StefanoMantero commented Jan 16, 2022 •
edited

What happened?

Currently, the global loadingBar component does not have a correctly implemented isActive reactive property. This has been asked in this issue.

What did you expect to happen?

In loadingbar.vue global file, the field Status: active/idle should update depending on the isActive prop that the global component have. This isn't happening as the Status is always in 'idle', since the $q.loadingBar.isActive is undefined.

Reproduction URL

https://codepen.io/stefanomantero/pen/RwLdbXx

How to reproduce?

  1. Create fresh quasar dev environment.
  2. Search for Loadingbar in GLOBAL
  3. Go to Loadingbar
  4. Add events both on $q or global
  5. See the idle Status not change.

Flavour

UMD

Areas

Components (quasar), Plugins (quasar)

Platforms/Browsers

Firefox, Chrome

Quasar info output

Operating System        Linux(5.4.72-microsoft-standard-WSL2) - linux/x64
NodeJs                  16.3.0

Global packages
  NPM                   7.15.1
  yarn                  Not installed
  @quasar/cli           1.2.2
  @quasar/icongenie     Not installed
  cordova               Not installed

Networking
  Host                  DESKTOP-93Q6Q5H
  eth0                  172.22.108.122

Relevant log output

No response

Additional context

No response
@github-actions github-actions bot added area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/umd labels Jan 16, 2022
@StefanoMantero
Copy link
Contributor Author

StefanoMantero commented Jan 16, 2022 •
edited

I have created the following pull request #12062

pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 17, 2022
@pdanpdan
fix(LoadingBar): don't overrwrite $q.loadingBar with the bar instance q…
2787276 
…uasarframework#12059

quasarframework#12059
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 17, 2022
@pdanpdan
fix(LoadingBar): don't overrwrite $q.loadingBar with the bar instance q…
bc901f9 
…uasarframework#12059

quasarframework#12059
@pdanpdan pdanpdan mentioned this issue Jan 17, 2022
Merged
rstoenescu pushed a commit that referenced this issue Jan 17, 2022
@pdanpdan
fix(LoadingBar): don't overrwrite $q.loadingBar with the bar instance #…
f75fcee 
…12059 (#12074)

#12059
rstoenescu pushed a commit that referenced this issue Jan 17, 2022
@StefanoMantero
fix(LoadingBar): Adding isActive reactive prop to loadingBar from issue
f039572 
#12059 (#12062)

* Added calls as reactive prop.

* Removed console log.

Co-authored-by: stefano_mantero_caim <stefano.mantero@caim.it>
@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.4.11 and v1.17.6

rstoenescu added a commit that referenced this issue Jan 17, 2022
@rstoenescu
fix(LoadingBar): isActive reactive prop #12059 (#12062)
dea3eb0
rstoenescu added a commit that referenced this issue Jan 17, 2022
@rstoenescu
fix(LoadingBar): isActive reactive prop #12059 (#12062)
c14e283
rstoenescu added a commit that referenced this issue Jan 17, 2022
@rstoenescu
fix(LoadingBar): isActive reactive prop #12059 (#12062); timing issue…
66533c9 
… when calling stop() + start() in same tick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/umd kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rstoenescu @StefanoMantero