Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep extend() turns Date objects into empty objects since v2.6.0 #12831

Closed
tiltec opened this issue Mar 17, 2022 · 1 comment
Closed

deep extend() turns Date objects into empty objects since v2.6.0 #12831

tiltec opened this issue Mar 17, 2022 · 1 comment
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@tiltec
Copy link

tiltec commented Mar 17, 2022 •
edited

What happened?

import { extend } from 'quasar'
const result = extend(true, {}, { d: new Date() })
console.log(result.d) // is '{}'!

What did you expect to happen?

Until v2.6.0, deep clone worked fine with Date objects.

I think this commit broke it: 75ffaa2

Non-deep clone is not affected by this.

Reproduction URL

https://codepen.io/tiltec/pen/OJzMLKe

How to reproduce?

HTML result is { "d": {} }, should be similar to { "d": "2022-03-17T08:57:26.935Z" }.

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

Components (quasar)

Platforms/Browsers

Firefox, Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

No response
@tiltec tiltec added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Mar 17, 2022
@github-actions github-actions bot added area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack labels Mar 17, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2022
@pdanpdan
fix(extend): revert to a simplified version of original extend quasar…
683a7f8 
…framework#12831

quasarframework#12831
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2022
@pdanpdan
fix(extend): revert to a simplified version of original extend quasar…
52eabe4 
…framework#12831

quasarframework#12831
rstoenescu added a commit that referenced this issue Mar 17, 2022
@rstoenescu
fix(ui): extend() method #12831
8d0bfb1
@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.6.2.

rstoenescu added a commit that referenced this issue Mar 17, 2022
@rstoenescu
fix(ui): extend() method #12831
7673ca2
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
f4d2353 
quasarframework#12831
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 18, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
e91c829 
quasarframework#12831
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 19, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
15df10a
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 19, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
80f01ea
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 25, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
89e4861
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 25, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
2e35f91
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 27, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
f68d486
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 27, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
40010e7
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 28, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
3c3f88c
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
82a8ff8
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 30, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
8cb627c
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 30, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
8d7d587
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 30, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
10d37ad
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 31, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
41ced2a
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 31, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
09cdc5e
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 31, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
f5a44fe
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 1, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
be2ee44
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 1, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
68c7ba8
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 4, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
fa772c4
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Aug 1, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
03e176f
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Aug 18, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
5ab4588
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 12, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
b835cbc
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 13, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
5293d26
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 14, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
3eacbde
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 14, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
29a4f07
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 14, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
39fbbd9
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 15, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
6400a6e
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 16, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
b4bf036
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 20, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
a5c4385
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 21, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
a7511f3
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 21, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
4fa0eb3
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 21, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
4cbcd5f
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 21, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
70ef1e1
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 22, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
6ef1ae8
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 22, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
36407ee
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 24, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
7106d99
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 25, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
26cc286
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 25, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
f73fb9b
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 27, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
a6b0517
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 27, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
2b96730
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 27, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
e08a0ee
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
d3ec310
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
5f41dc2
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
e00318a
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
5434f34
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
10b0900
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 29, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
8107c5e
rstoenescu added a commit that referenced this issue Sep 30, 2022
@pdanpdan @rstoenescu
fix(extend): small tweaks for extend #12831 (#14518)
2bb5f30 
* fix(extend): small tweaks for extend #12831

* Update extend.js

Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 30, 2022
@pdanpdan
fix(extend): small tweaks for extend quasarframework#12831
9938af8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiltec @rstoenescu