Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot tab forward on Quasar Plugin cancel button #12871

Closed
gwynncausing opened this issue Mar 21, 2022 · 5 comments
Closed

Cannot tab forward on Quasar Plugin cancel button #12871

gwynncausing opened this issue Mar 21, 2022 · 5 comments
Labels
area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. kind/bug 🐞 Qv1

Comments

@gwynncausing
Copy link

gwynncausing commented Mar 21, 2022

What happened?

when tabbing continuously in the Dialog, it will not focus in the cancel button.

What did you expect to happen?

It should be able to focus

Reproduction URL

https://codepen.io/gwynncausing/pen/popNjpX

How to reproduce?

  1. Open the reproduction link or visit this link, this is from quasar website.
  2. Open any Dialog that has cancel and OK in it.
  3. Press tab multiple times

Flavour

Quasar CLI (@quasar/cli | @quasar/app)

Areas

Components (quasar), Plugins (quasar)

Platforms/Browsers

Chrome, Microsoft Edge

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@github-actions github-actions bot added area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. labels Mar 21, 2022
@rstoenescu
Copy link
Member

Shift-tab would do the trick. The "OK" button is set as default go-to for focus.
But I see your point. Will exchange positions of OK with Cancel.

@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.6.3 and v1.18.8

@pdanpdan
Copy link
Collaborator

I've never seen a dialog with the cancel button in the primary position.
https://material.io/components/dialogs#anatomy

pdanpdan pushed a commit to pdanpdan/quasar that referenced this issue Mar 29, 2022
pdanpdan pushed a commit to pdanpdan/quasar that referenced this issue Mar 30, 2022
pdanpdan pushed a commit to pdanpdan/quasar that referenced this issue Mar 30, 2022
pdanpdan pushed a commit to pdanpdan/quasar that referenced this issue Mar 31, 2022
pdanpdan pushed a commit to pdanpdan/quasar that referenced this issue Mar 31, 2022
@Nisgrak
Copy link

Nisgrak commented Mar 31, 2022

This change needs to be a MAJOR version, this is almost a breaking change...

Anyway this not looks good in a Dialog, even the Material spec says the accept button must be in rigth like @pdanpdan says:
image

@rstoenescu
Copy link
Member

Working on another fix rather than switching buttons order, but in the meantime we can't leave out important functionality.

rstoenescu added a commit that referenced this issue Apr 1, 2022
…t time; then on focusing out it should look for any focusable element; also revert DialogPlugin button order #12871
rstoenescu added a commit that referenced this issue Apr 1, 2022
…ofocusable only first time; then on focusing out it should look for any focusable element; also revert DialogPlugin button order #12871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. kind/bug 🐞 Qv1
Projects
None yet
Development

No branches or pull requests

4 participants