Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QSlider): fix odd behavior on key down when set vertical mode (fix: #13132) #14385

Merged
merged 10 commits into from Sep 14, 2022

Conversation

madosuki
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
close #13132

Currently(v2.7.7) QSlider behavior when on vertical mode is odd. ref https://quasar.dev/vue-components/slider#vertical

Currently behavior is when press the down arrow key then ring move to up, when press the up arrow key oppose behavior that.

I think intuitively correct behavior is when press the down arrow key then ring move to down and when press the up arrow key is oppose behavior that.

@madosuki madosuki changed the title fix(QSlider): fix odd behavior on key down when set vertical mode fix(QSlider): fix odd behavior on key down when set vertical mode (fix: ##13132) Sep 14, 2022
@madosuki madosuki changed the title fix(QSlider): fix odd behavior on key down when set vertical mode (fix: ##13132) fix(QSlider): fix odd behavior on key down when set vertical mode (fix: #13132) Sep 14, 2022
@rstoenescu rstoenescu merged commit e8d602b into quasarframework:dev Sep 14, 2022
@rstoenescu
Copy link
Member

Thanks for contributing!
Changed it a bit and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] Vertical: Keyboard edit (up/down keys) has very weird logic
2 participants