Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QSlider): fix odd behavior on key down when set vertical mode (fix: #13132) #14385

Merged
merged 10 commits into from
Sep 14, 2022
Merged

fix(QSlider): fix odd behavior on key down when set vertical mode (fix: #13132) #14385

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
65dcc6f
test changes
madosuki Sep 14, 2022
93551f8
re changes
madosuki Sep 14, 2022
d06217e
change lambda function name
madosuki Sep 14, 2022
6fc168d
Merge branch 'quasarframework:dev' into fix_qslider_behaviour
madosuki Sep 14, 2022
23ebea7
reduce lines
madosuki Sep 14, 2022
57d97b2
Merge branch 'fix_qslider_behaviour' of github.com:madosuki/quasar in…
madosuki Sep 14, 2022
f14dfb0
Merge branch 'quasarframework:dev' into fix_qslider_behaviour
madosuki Sep 14, 2022
f8a837e
Update QSlider.js
rstoenescu Sep 14, 2022
154f69e
Update use-slider.js
rstoenescu Sep 14, 2022
d4bcdc8
Update use-slider.js
rstoenescu Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/src/components/slider/QSlider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@ export default createComponent({

const
stepVal = ([ 34, 33 ].includes(evt.keyCode) ? 10 : 1) * state.step.value,
offset = ([ 34, 37, 40 ].includes(evt.keyCode) ? -1 : 1) * (state.isReversed.value === true ? -1 : 1) * stepVal
offset = (
([ 34, 37, 40 ].includes(evt.keyCode) ? -1 : 1)
* (state.isReversed.value === true ? -1 : 1)
* (props.vertical === true ? -1 : 1) * stepVal
)

model.value = between(
parseFloat((model.value + offset).toFixed(state.decimals.value)),
Expand Down