Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QFile multiple select bug #14406

Closed
olegbaturin opened this issue Sep 16, 2022 · 6 comments
Closed

QFile multiple select bug #14406

olegbaturin opened this issue Sep 16, 2022 · 6 comments
Labels
area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar has PR 💯 kind/bug 🐞 Qv1 Qv2 🔝 Quasar v2 issues

Comments

@olegbaturin
Copy link

What happened?

  1. Select only 'file1'
  2. Select 'file1' and 'file2'
  3. Only 'file2' is selected

What did you expect to happen?

'file1' and 'file2' selected

Reproduction URL

https://quasar.dev/vue-components/file-picker#example--multiple-files

How to reproduce?

  1. Select only 'file1'
  2. Select 'file1' and 'file2'
  3. Only 'file2' is selected

Flavour

Vite Plugin (@quasar/vite-plugin)

Areas

Components (quasar)

Platforms/Browsers

Firefox, Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@github-actions github-actions bot added area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar labels Sep 16, 2022
@github-actions
Copy link

Hi @olegbaturin! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, StackBlitz, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.8.3 and 1.20.1

rstoenescu added a commit that referenced this issue Sep 16, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 16, 2022
@olegbaturin
Copy link
Author

Now if append="true" duplicates are not removed. And if append="false", previous selection [file1, file2] is not cleared if [file1] is selected.

@olegbaturin
Copy link
Author

this commit d40477b works fine

@pdanpdan
Copy link
Collaborator

The current solution is better, just the check is the other way around, it'll be fixed in next version.

@pdanpdan pdanpdan reopened this Sep 17, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 17, 2022
@olegbaturin
Copy link
Author

ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar has PR 💯 kind/bug 🐞 Qv1 Qv2 🔝 Quasar v2 issues
Projects
None yet
3 participants