Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-label should be set to Remove only in removable state of QChip #14561

Closed
dwaxweiler opened this issue Oct 5, 2022 · 1 comment
Closed

aria-label should be set to Remove only in removable state of QChip #14561

dwaxweiler opened this issue Oct 5, 2022 · 1 comment
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@dwaxweiler
Copy link

dwaxweiler commented Oct 5, 2022 •
edited

What happened?

Since #14388 has been merged for version 2.8.4, the aria-label is set to Remove by default on clickable state of QChip. Alternatively remove-aria-label can be set to have a different text. The clickable state is not equal to the removable state.

What did you expect to happen?

The aria-label should not be set to Remove or to the value of remove-aria-label on QChip when it is in clickable state. It is fine for removable state though.

Reproduction URL

https://jsfiddle.net/de1zgk67/

How to reproduce?

  1. Go to the provided reproduction link.
  2. Inspect the QChip element in DevTools
  3. Notice that the div tag with the class q-chip has aria-label="Remove".

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Components (quasar)

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response
@dwaxweiler dwaxweiler added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Oct 5, 2022
@github-actions github-actions bot added area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite labels Oct 5, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 5, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button quasarfram…
5bf6aee 
…ework#14561
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 5, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button quasarfram…
65f471b 
…ework#14561
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 5, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button quasarfram…
84afaec 
…ework#14561
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 5, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button quasarfram…
25b4192 
…ework#14561
rstoenescu pushed a commit that referenced this issue Oct 6, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button #14561 (#1…
a76708e 
…4565)
rstoenescu pushed a commit that referenced this issue Oct 6, 2022
@pdanpdan
fix(QChip): use sepparate attrs for chip and remove button #14561 (#1…
0c294b7 
…4566)
@pdanpdan
Copy link
Collaborator

pdanpdan commented Oct 6, 2022

Will be fixed in next version of Qv1 and Qv2

@pdanpdan pdanpdan closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdanpdan @dwaxweiler