Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(QBreadcrumbsEl): remove un-used 'ripple' prop #14603

Merged
merged 1 commit into from Oct 12, 2022

Conversation

KareemDa
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@MilosPaunovic
Copy link
Member

@KareemDa Hmm... I'm thinking out loud now... Do we want to remove the reference to Ripple here, or do we, potentially, want to implement it properly...?

Let's wait for someone else to weigh in on this.

@rstoenescu rstoenescu merged commit 12459e5 into quasarframework:dev Oct 12, 2022
@rstoenescu
Copy link
Member

Ripple can be attached in devland, so no point in adding a prop for it.
Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants