Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid TypeScript types for QDialogOption's prompt and options #14766

Closed
Shinigami92 opened this issue Nov 1, 2022 · 3 comments · Fixed by #14781
Closed

Invalid TypeScript types for QDialogOption's prompt and options #14766

Shinigami92 opened this issue Nov 1, 2022 · 3 comments · Fixed by #14781
Assignees
Labels
area/plugins area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/vite-plugin Bugs related to Vite usage with Quasar kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@Shinigami92
Copy link
Contributor

What happened?

When upgrading quasar to v2.10.1 and then run vue-tsc I get following errors:

> vue-tsc --noEmit && vite build

node_modules/.pnpm/quasar@2.10.1/node_modules/quasar/dist/types/index.d.ts:13315:5 - error TS2374: Duplicate index signature for type 'string'.

13315     [QInputProps: string]: any;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/quasar@2.10.1/node_modules/quasar/dist/types/index.d.ts:13319:5 - error TS2374: Duplicate index signature for type 'string'.

13319     [nativeAttributes: string]: any;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/quasar@2.10.1/node_modules/quasar/dist/types/index.d.ts:13347:5 - error TS2374: Duplicate index signature for type 'string'.

13347     [QOptionGroupProps: string]: any;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/quasar@2.10.1/node_modules/quasar/dist/types/index.d.ts:13351:5 - error TS2374: Duplicate index signature for type 'string'.

13351     [nativeAttributes: string]: any;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 4 errors in the same file, starting at: node_modules/.pnpm/quasar@2.10.1/node_modules/quasar/dist/types/index.d.ts:13315

 ELIFECYCLE  Command failed with exit code 2.

What did you expect to happen?

No errors

Reproduction URL

Will provide if needed later on

How to reproduce?

Install quasar
Look into node_modules/quasar/dist/types/index.d.ts lines 13315, 13319, 13347 and 13351

Flavour

Vite Plugin (@quasar/vite-plugin)

Areas

Components (quasar), TypeScript Support

Platforms/Browsers

No response

Quasar info output

I'm using vite plugin, so I don't have `quasar info`

Relevant log output

No response

Additional context

image

image

@github-actions github-actions bot added area/components area/typescript bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar labels Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hi @Shinigami92! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, StackBlitz, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

@Shinigami92
Copy link
Contributor Author

Pinning quasar to 2.10.0 fixes this for now!
So this came in in the last bug-fix version

@yusufkandemir yusufkandemir added bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. area/plugins and removed bug/0-needs-info Need more info to reproduce area/components labels Nov 1, 2022
@yusufkandemir
Copy link
Member

Caused by fb9bdaf#diff-9b1d6b642d3c0d9d26b5eb502da68e9e755e4026e27283a6a496b3ead2e9277f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/vite-plugin Bugs related to Vite usage with Quasar kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants