Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor/Cordova: www folder not cleaned up before build #15186

Closed
yxyx-github opened this issue Dec 28, 2022 · 2 comments
Closed

Capacitor/Cordova: www folder not cleaned up before build #15186

yxyx-github opened this issue Dec 28, 2022 · 2 comments
Assignees
Labels
bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/quasar-cli-vite flavour/quasar-cli-webpack kind/bug 🐞 mode/capacitor Qv2 🔝 Quasar v2 issues

Comments

@yxyx-github
Copy link

Description

When upgrading Capacitor as described in the documentation (see the link below), you should also delete the www folder, otherwise the bundle files will be created twice (or even more), which will make the final APK file unnecessarily large.
The more often you perform the upgrade steps, the more duplicates will result.
So I would suggest to add the www folder to the folders to delete in the first step of the Upgrade guide in the documentation.
I don't know if this only occurs with Vite because I did not test it with Webpack.

Thanks for all your work for such a great framework! I wish you a happy new year!

Documentation Section URL

https://quasar.dev/quasar-cli-vite/developing-capacitor-apps/capacitor-version-support#upgrading-capacitor

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Capacitor Mode

@rstoenescu rstoenescu self-assigned this Jan 14, 2023
@rstoenescu rstoenescu added kind/bug 🐞 bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. and removed kind/docs 📄 flavour/quasar-cli-vite labels Jan 14, 2023
@rstoenescu
Copy link
Member

Hi,

This is not a documentation bug. But an actual bug in both q/app-vite and q/app-webpack.
Fixing...

@rstoenescu rstoenescu changed the title Also delete www folder when upgrading capacitor Capacitor: www folder not cleaned up before build Jan 14, 2023
@rstoenescu rstoenescu changed the title Capacitor: www folder not cleaned up before build Capacitor/Cordova: www folder not cleaned up before build Jan 14, 2023
@rstoenescu
Copy link
Member

Fix will be available in q/app-vite v1.1.4 and q/app-webpack v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/quasar-cli-vite flavour/quasar-cli-webpack kind/bug 🐞 mode/capacitor Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants