Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheet: typing issue #15893

Closed
lambda0xff opened this issue May 24, 2023 · 4 comments
Closed

BottomSheet: typing issue #15893

lambda0xff opened this issue May 24, 2023 · 4 comments
Labels
area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@lambda0xff
Copy link

What happened?

Typing is wrong for BottomSheet:actions:avatar

What did you expect to happen?

Current type is avatar?: boolean.
Should probably be avatar?: string

Reproduction URL

https://codepen.io/rstoenescu/pen/xxEvBLR

How to reproduce?

note: codepen irrelevant

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Plugins (quasar)

Platforms/Browsers

Chrome

Quasar info output

2   │ Operating System - Darwin(22.4.0) - d
       │ arwin/x64
   3   │ NodeJs - 18.16.0
   4   │
   5   │ Global packages
   6   │   NPM - 9.5.1
   7   │   yarn - 1.22.19
   8   │   @quasar/cli - 2.2.1
   9   │   @quasar/icongenie - 3.0.0
  10   │   cordova - Not installed
  11   │
  12   │ Important local packages
  13   │   quasar - 2.12.0 -- Build high-perfo
       │ rmance VueJS user interfaces (SPA, PW
       │ A, SSR, Mobile and Desktop) in record
       │  time
  14   │   @quasar/app-vite - 1.4.3 -- Quasar
       │ Framework App CLI with Vite
  15   │   @quasar/extras - 1.16.4 -- Quasar F
       │ ramework fonts, icons and animations
  16   │   eslint-plugin-quasar - Not installe
       │ d
  17   │   vue - 3.3.4 -- The progressive Java
       │ Script framework for building modern
       │ web UI.
  18   │   vue-router - 4.2.1
  19   │   pinia - Not installed
  20   │   vuex - Not installed
  21   │   vite - 2.9.15 -- Native-ESM powered
       │  web dev build tool
  22   │   eslint - Not installed
  23   │   electron - Not installed
  24   │   electron-packager - Not installed
  25   │   electron-builder - Not installed
  26   │   register-service-worker - 1.7.2 --
       │ Script for registering service worker
       │ , with hooks
  27   │   @capacitor/core - Not installed
  28   │   @capacitor/cli - Not installed
  29   │   @capacitor/android - Not installed
  30   │   @capacitor/ios - Not installed
  31   │
  32   │ Quasar App Extensions
  33   │   *None installed*
  34   │
  35   │ Networking
  36   │   Host - lambda0xffs-Mac-mini.local
  37   │   en1 - 192.168.1.110

Relevant log output

No response

Additional context

No response

@github-actions github-actions bot added area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite labels May 24, 2023
@lambda0xff
Copy link
Author

Screenshot 2023-05-24 at 15 26 27

@rstoenescu
Copy link
Member

The avatar prop IS boolean. It just tells to display the img param as avatar. Use both "img" and "avatar: true".

@lambda0xff
Copy link
Author

I don't know, maybe I missed something ?

https://codepen.io/lambda0xff/pen/YzJBMWW?editors=1010

Also, from the source code: const img = action.avatar || action.img

@rstoenescu
Copy link
Member

Ahhh. Apologies, you are right. Fixed it. Will be available in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants