Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearable QInput & QSelect does not work with "Enter" #16522

Open
Marcindyg opened this issue Oct 26, 2023 · 2 comments
Open

Clearable QInput & QSelect does not work with "Enter" #16522

Marcindyg opened this issue Oct 26, 2023 · 2 comments
Labels
area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@Marcindyg
Copy link

What happened?

In QInput and QSelect with prop "clearable" button/icon "x" works correctly on mouse click but does not always work with "Enter" keypress when button/icon is focused. Sometimes like in "Clearable" example #2 in QInput icon "x" is not even focusable.

https://quasar.dev/vue-components/input#example--clearable
In docs page with "Clearable" example we have 3 cases:

  1. ❌ "x" is focusable but "Enter" did nothing
  2. ❌ "x" is not focusable (but it's because slot example is poor)
  3. ✅ "x" is focusable and "Enter" clear value

What did you expect to happen?

Whenever "clerable" QIinput or QSelect is not disabled i expect that "x" icon is focusable and with "Enter" keypress value will be cleared.

Reproduction URL

https://quasar.dev/vue-components/input#example--clearable

How to reproduce?

Try to clear with "Enter" examples in QInput "clearable"

QInput "clearable" examples extracted to separate codepen works correctly, so i assume bug is not directly in those components*

*Same for QSelect

Flavour

Vite Plugin (@quasar/vite-plugin)

Areas

Components (quasar)

Platforms/Browsers

Firefox, Chrome, Microsoft Edge

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@Marcindyg Marcindyg added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Oct 26, 2023
@github-actions github-actions bot added area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar labels Oct 26, 2023
@github-actions
Copy link

Hi @Marcindyg! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, StackBlitz, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

@pdanpdan
Copy link
Collaborator

pdanpdan commented Nov 9, 2023

In fact it is a bug with QIcon, which does not use tag to render when icon is SVG.
With that bug fixed the first and third examples are all good, and the second one is like this by default, to show how to create not-focusable clear icons (lots of people do not want to be focusable).

So please open another issue about QIcon and then I'll close this one. Thank you

pdanpdan added a commit to pdanpdan/quasar that referenced this issue Nov 9, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Nov 9, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components bug/0-needs-info Need more info to reproduce flavour/vite-plugin Bugs related to Vite usage with Quasar kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants