Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCard assumes any color it's set to is dark #2546

Closed
tmladek opened this issue Sep 12, 2018 · 3 comments
Closed

QCard assumes any color it's set to is dark #2546

tmladek opened this issue Sep 12, 2018 · 3 comments
Milestone

Comments

@tmladek
Copy link

tmladek commented Sep 12, 2018

Software version

Operating System Linux(4.17.0-3-amd64) - linux/x64
NodeJs 8.11.4

Global packages
NPM 6.4.0
yarn 1.9.4
quasar-cli 0.17.13
cordova 8.0.0

Important local packages
quasar-cli 0.17.13 (Quasar Framework CLI)
quasar-framework 0.17.10 (Build responsive SPA, SSR, PWA, Hybrid Mobile Apps and Electron apps, all simultaneously using the same codebase)
quasar-extras 2.0.6 (Quasar Framework fonts, icons and animations)
vue 2.5.17 (Reactive, component-oriented view layer for modern web interfaces.)

Browsers: Firefox, Chrome

JsFiddle

https://jsfiddle.net/mo65bq0n/
https://jsfiddle.net/gb8h79o1/4/

What did you get as the error?

No matter what color I pass as the color prop to QCard, it colors the text white and adds a q-card-dark class to the outermost <div> of the QCard, which also causes the separator to be white.

This happens even when setting the color to white, which means the QCard appears completely blank.

Text color can be overriden using the textColor, but this doesn’t change the color of the separator.

What were you expecting?

The card's text and separator to remain black.

This happens to multiple people apparently: https://forum.quasar-framework.org/topic/2681/qcard-assumes-any-color-i-set-is-dark

@rstoenescu
Copy link
Member

Added a Boolean dark prop to QCard, to be used only when color is dark. Will be available in Quasar v0.17.13.

@tmladek
Copy link
Author

tmladek commented Sep 13, 2018

Thank you! However, I hope this won't break any projects which rely on the fact that QCard does in fact assume that and will be missing the dark prop.

ghys added a commit to openhab/org.openhab.ui.habot that referenced this issue Sep 26, 2018
Card deck filters: menu was not always appearing in Firefox
Use a web app manifest in statics to precache (prevent asking for credentials)
JSON Editor in card designer was broken
Fix suggestion chip at start of chat (also it is now dynamic)
Make the SW work again in dev mode
Consider all colored cards dark (temp. fix for quasarframework/quasar#2546 (comment), should/will add an option)

Signed-off-by: Yannick Schaus <habpanel@schaus.net>
@tmladek
Copy link
Author

tmladek commented Oct 16, 2018

Hello again, this issue is still not fixed (or maybe broken again?) in the current version (v.0.17.17), as you can see by re-running the JSFiddles, this time not because of the q-card-dark class, but because of the text-white class. The dark prop seems to have no effect.

What happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants