Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1] Disabled button with v-close-dialog closes QDialog #3404

Closed
dmig opened this issue Feb 27, 2019 · 1 comment · Fixed by #3407
Closed

[v1] Disabled button with v-close-dialog closes QDialog #3404

dmig opened this issue Feb 27, 2019 · 1 comment · Fixed by #3407

Comments

@dmig
Copy link

dmig commented Feb 27, 2019

I have a QDialog with form in it. Dialog submit button has both v-close-dialog and disable property. The latter is connected to simple validation computed which ensures all fields are filled.

Software version

Quasar: v1.0.0-beta.4
@quasar/app (v1+ only): v1.0.0-beta.8
OS: Linux(4.18.20-041820-generic) - linux/x64
Node: 10.2.1
NPM: 6.8.0
Browsers: Chromium 71.0.3578.98
Any other software related to your bug:

JsFiddle

https://jsfiddle.net/dmig/4sqkf8n1/6/

What did you get as the error?

Clicking "submit" button closes dialog even when it's disabled.

What were you expecting?

Clicking "submit" button does nothing.

What steps did you take, to get the error?

See fiddle
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 27, 2019
@pdanpdan
feat(quasar): Allow disabling VCloseDialog and VCloseMenu using value
e61a7b1 
close quasarframework#3404
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 27, 2019
@pdanpdan
feat(quasar): Allow disabling VCloseDialog and VCloseMenu using value
862ece3 
close quasarframework#3404
@pdanpdan pdanpdan mentioned this issue Feb 27, 2019
Merged
rstoenescu pushed a commit that referenced this issue Feb 27, 2019
@pdanpdan @rstoenescu
feat(quasar): Allow disabling VCloseDialog and VCloseMenu using value (…
127aa26 
…#3407)

* feat(quasar): Allow disabling VCloseDialog and VCloseMenu using value

close #3404

* Update CloseDialog.json

* Update CloseMenu.js

* Update CloseMenu.json
@rstoenescu
Copy link
Member

Enhancement will be available in beta.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(quasar): Allow disabling VCloseDialog and VCloseMenu using value pdanpdan/quasar
2 participants
@dmig @rstoenescu