Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking a modal close button multiple times quickly will send you back a page #343

Closed
jsfeldman opened this issue Jan 24, 2017 · 3 comments
Closed

Clicking a modal close button multiple times quickly will send you back a page #343

jsfeldman opened this issue Jan 24, 2017 · 3 comments
Milestone
v0.13

Comments

@jsfeldman
Copy link
Contributor

If you click a modal close button multiple times quickly you will be sent back a page instead of just closing the modal. I believe what is happening is that the close event from hitting the close modal button is triggered as well as the close event from clicking outside of the modal.

Let me know if you're not experiencing it or if you need any other information.
@rstoenescu
Copy link
Member

Are you using edge or v0.12?

@rstoenescu
Copy link
Member

Fixed for v0.13 and in edge.

@rstoenescu rstoenescu added this to the v0.13 milestone Jan 24, 2017
@jsfeldman
Copy link
Contributor Author

I'm using v0.12. Awesome! Thanks.

n05la3 added a commit to n05la3/quasar that referenced this issue Mar 5, 2024
@n05la3
test(QSelect): explicty ensure elements are visible before clicking, fix
1b36891 
 quasarframework#343

- The QSelect random failure is caused by clicking on an element when it is not yet visible. Following, cypress' actionability, it is supposed to check that an element is not hidden before clicking but this is seems not to be working as expected. So "should('be.visible')" has been explicity added to ensure tests are more deterministic
n05la3 added a commit to n05la3/quasar that referenced this issue Mar 5, 2024
@n05la3
test(QSelect): explicity check for visibility before clicking, fixes q…
800c9b7 
…uasarframework#343

- The QSelect random failure is caused by clicking on an element when it is not yet visible. Following cypress' actionability requirements, it is supposed to check that an element is not hidden before clicking but this is seems not to be working as expected. So "should('be.visible')" checks have been explicity added to ensure tests are more deterministic
n05la3 added a commit to n05la3/quasar that referenced this issue Mar 5, 2024
@n05la3
test(QSelect): explicity check for visibility before clicking, fixes q…
6514fd8 
…uasarframework#343

- The QSelect random failure is probably caused by clicking on an element when it is not yet visible. Even though cypress is supposed to check that an element is visible before clicking, sometimes due to race conditions or for some other reason, the element may be found and clicked when it is not yet visible. So "should('be.visible')" has been explicitly added to ensure tests are deterministic
n05la3 added a commit to n05la3/quasar that referenced this issue Mar 5, 2024
@n05la3
test(QSelect): explicity check for visibility before clicking, fixes q…
731ad38 
…uasarframework#343

- The QSelect random failure is probably caused by clicking on an element when it is not yet visible. Even though cypress is supposed to check that an element is visible before clicking, sometimes due to race conditions or for some other reason, the element may be found and clicked when it is not yet visible. So "should('be.visible')" has been explicitly added to ensure tests are deterministic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13
Development

No branches or pull requests
2 participants
@rstoenescu @jsfeldman