[v1] Notify config defaults and Invalid handler for event "click": got undefined

[smakinson]

When I configure some defaults in quasar.conf for Notify, I see the following error in the console:

Notify config and Invalid handler for event "click": got undefined

and clicking the button does not dismiss the notification. I think I am reading the docs correctly about not needing to specify a handler to get the notification to close.

If a 'handler' is specified or not, clicking/tapping on the button will also close the notification

However, adding a handler to the defaults does not fix the error.

Software version

Quasar: beta 13
@quasar/app (v1+ only): beta 13
OS:
Node:
NPM:
Browsers:
iOS:
Android:
Any other software related to your bug:

I don't think I can create a codepen for this one, can I?

What did you get as the error?

In the console: Invalid handler for event "click": got undefined

What were you expecting?

No console error and the Notify close button to close the notification.

What steps did you take, to get the error?

Added this under config in quasar.conf:

 notify: {
   textColor: 'white',
   actions: [{ icon: 'close', color: 'white' }]
}

this also does not correct the issue:

 notify: {
   textColor: 'white',
   actions: [{ icon: 'close', color: 'white', handler: () => {} }]
}

[rstoenescu]

Hi,

There is a limitation that you cannot specify functions under quasar.conf.js > framework > config.
If you need a function in your case (actions -> handler), then create a boot file where you import { Notify } from 'quasar' and use the Notify.setDefaults() method.

[smakinson]

@rstoenescu I see. I don't actually need a function, I only tried adding it there to see if it prevented the console error. I see the console error with out the function in the config also. Should it be valid to use only the icon & color in the config? If so, am I reading the docs correctly that ( assuming the console error was not there ) by providing an action with an icon, it should close itself when the button is clicked? If not, using the setDefaults is cool, I just wanted to make sure this is definitely not a bug.

[smakinson]

If I take the defaults out of quasar.conf and move it to

Notify.setDefaults({
    textColor: 'white',
    actions: [{ icon: 'close', color: 'white' }]
  })

I see the same error in the console.

[rstoenescu]

Isn't the outcome normal? You haven't defined your handler too.

Notify.setDefaults({
    textColor: 'white',
    actions: [{ icon: 'close', color: 'white', handler: .... }]
  })

[smakinson]

Setting a handler does prevent the error when setting the defaults from Notify.setDefaults, but clicking the button does not close the notification.

Maybe its just the wording in the docs:

If a 'handler' is specified or not, clicking/tapping on the button will also close the notification

where is says specified or not that causes me to wonder if I was seeing a bug. I read that as specifying a handler is optional and if I don't it will still close the notification when the button it clicked/tapped. Might I just be misunderstanding that or should it be reworded? Sorry it could just be me.

[rstoenescu]

@pdanpdan Do you have a bit of time to investigate and see what's going on pls?

[rstoenescu]

Improved setting defaults through setDefaults method. Will be available in beta.18. I suggest you read the newly added section (Setting defaults) after this release.

[smakinson]

Thank you!