Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.1 request] To make style (skin) compiler #4354

Closed
DmitrijOkeanij opened this issue Jun 11, 2019 · 1 comment
Closed

[v1.1 request] To make style (skin) compiler #4354

DmitrijOkeanij opened this issue Jun 11, 2019 · 1 comment

Comments

@DmitrijOkeanij
Copy link
Contributor

Skin compiler.

My thoughts.

I am building skin system for my site engine, and on now technologies it is difficult to achieve.
I think this is common case for many projects, to apply customs skins.

What is skin?
Some aditional css styles above Qausar CSS.

To build custom skin I need

  1. Some command to compile my stylus skin file. It may be extension.
    I dont know the extensions syntax but it can be something like this
    quasar compile-skin my-skin.styl
    And this command produce css code in one file => my-skin.css
  2. I need to apply my-skin.css to the site, so Quasar Api need to have function to apply
import {applySkin} from "quasar"
applySkin("MySkin", "/somedir/my-skin.css");  //  1 parameter is skin name, it needed to remove skin by name.
  1. And to remove skin
    removeSkin("MySkin")
  2. Ability to add many skins at one time.
applySkin("MySkin", "/somedir/my-skin.css");
applySkin("Skin2", "/somedir/my-skin2.css");
applySkin("Skin3", "/somedir/my-skin3.css");

It needed to skin different components separetly if I want.

  1. Ability to remove many skins
removeAllSkins()
removeSkins(["MySkin","Skin1"]);

This is my vision of how skins have to work.

@DmitrijOkeanij DmitrijOkeanij changed the title [v1.1 request] To make style (skin) compiler [v1 request] To make style (skin) compiler Jun 11, 2019
@DmitrijOkeanij DmitrijOkeanij changed the title [v1 request] To make style (skin) compiler [v1.1 request] To make style (skin) compiler Jun 11, 2019
@nothingismagick
Copy link
Contributor

Please close this issue. It will be addressed in the RFC for theming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants