Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Ability to overwrite VueRouterBase from quasar.conf.js #5845

Closed
rossity opened this issue Dec 10, 2019 · 1 comment
Closed

[Request] Ability to overwrite VueRouterBase from quasar.conf.js #5845

rossity opened this issue Dec 10, 2019 · 1 comment

Comments

@rossity
Copy link
Contributor

rossity commented Dec 10, 2019

Is your feature request related to a problem? Please describe.
I can update the publicPath which updates all my assets to their CDN urls, but it also updates VueRouterBase url to use the CDN URL which throws security errors and prevents the app from rendering.

Describe the solution you'd like
Add vueRouterBase to quasar.conf.js inside build

Describe alternatives you've considered
I tried overriding it in router/index.js too and it still kept the same url as the publicPath override.
Also changing the process.env.VUE_ROUTER_BASE in quasar.conf.js does not appear to work either.

@rstoenescu
Copy link
Member

rstoenescu commented Dec 17, 2019

Will be available in "@quasar/app" v1.4.2.

You can already change it by overwriting the base: process.env.VUE_ROUTER_BASE line with your desired value :) But added quasar.conf.js > build > vueRouterBase in "@quasar/app" v1.4.2.

I've seen people wanting to change app base and the router base often, but I cannot stress enough that changing any of these will most likely break your app completely. Be sure that you really want to override the quasar/app computed value for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants