Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dialog not closing on back button on Capacitor build #6134

Closed
vycoder opened this issue Jan 16, 2020 · 4 comments
Closed

[Bug] Dialog not closing on back button on Capacitor build #6134

vycoder opened this issue Jan 16, 2020 · 4 comments

Comments

@vycoder
Copy link

vycoder commented Jan 16, 2020

Describe the bug
QDialog doesn't close when device back button is clicked on Capacitor apps. Cordova works fine as is but for some reason on Capacitor build, nothing happens when device's back button is pressed.

Codepen/jsFiddle/Codesandbox (required)
Any non-persistent QDialog ie: https://codepen.io/yev/pen/dyPqjJp

To Reproduce
Steps to reproduce the behavior:

  1. Create a fresh Quasar project
  2. Use plain QDialog component
  3. Make sure persistent prop is not set
  4. Add capacitor mode
  5. Build android apk
  6. Install, open app and open dialog
  7. Click device back button
  8. Nothing happens

Expected behavior
The dialog should close same behavior like hitting esc-key.

Platform (please complete the following information):
OS: Pop!_OS
Node: v12.4.0
NPM: 6.9.0
Yarn: 1.21.1
Browsers: Chrome
iOS:
Android: Android 8.0 Oreo
Electron:

@pdanpdan
Copy link
Collaborator

Try to follow here: ionic-team/capacitor#417

@vycoder
Copy link
Author

vycoder commented Jan 16, 2020

@pdanpdan it looks like that specific issue is already fixed. I'm not particularly sure why it happens on quasar capacitor build though. Is there any more information that might explain what happens based on the related capacitor issue?

@rstoenescu
Copy link
Member

Will do a test (in the next days) to see if the Capacitor API supports this correctly and will update Quasar. We currently allow the auto closing behavior on Cordova only.

@rstoenescu
Copy link
Member

This will be available in "quasar" v1.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants