QUploader - Uploading same file twice

[jd-solanki]

Describe the bug

BUG 1: If we upload same file twice or files with same name, uploader component gives duplicate key warning. You can check it in the multiple demo of quasar docs.

BUG 2: Now if we remove any file from duplicates, all images with that name get removed.

Codepen/jsFiddle/Codesandbox (required)
BUG 1: You can check this in multiple demo in quasar docs
BUG 2: Same

To Reproduce

Bug 1
Steps to reproduce the behavior:

1. Go to above link in docs
2. Click on codepen icon
3. In first demo of multiple upload same file twice.
4. Check console.
5. See error

Bug 2

1. Follow above steps and try to remove any of duplicate files.
2. Both files will get removed even if we remove on one.

Expected behavior
Files with same name should not give error. This can easily get handled by index. And for removing file, only that file should get removed.

Screenshots

Platform (please complete the following information):
OS: Ubuntu
Node: 12
NPM: 6.13.4
Yarn: 1.21.1
Browsers: Chrome
iOS: Not tested
Android: Not tested
Electron: Not tested

Additional context
I think index should be used to mitigate duplicate keys warning. For bug-2 index kind of thing should do it.

I love to make PR but I am not yet fully understand how quasar handles same code on all devices. So I can not.

~ Thanks for developing such great framework

[jd-solanki]

Sorry for the issue. I was trying to make PR and found that it is already handled.

How: Files with same name will not be added in uploader.

Closing this.

[jd-solanki]

It is still not working in package. I checked node_modules folder and found that code is not present in source.

[rstoenescu]

What code is not present in the source?

[jd-solanki]

Hi, @rstoenescu
repo clone:

Node Modules:

[jd-solanki]

Duplicate key issue can be mitigated if we use slot and render list on our but removing file still removes files with same name.

[rstoenescu]

Then update your project's Quasar version... It means you are on an older version.

[jd-solanki]

Hello @rstoenescu I am already on latest version 1.9.7. You can check this issue in codepen also if you like.

[rstoenescu]

With all due respect, we ship what it is on our repo, not something else. So please figure out why you have other version installed. Thank you.

[jd-solanki]

Hi @rstoenescu,
Sorry for the trouble. I have inspected the issue and found that this exist in the latest version of the quasar framework.

I have made a clone few days back(or maybe a month). In that version, code was present to prevent duplicates. So, this was the confusion. I am really sorry.

But I am sure that this issue still exist in latest/current version of quasar qUploader. So can you please open this issue again.

You can check this issue in codePen.

~ Thanks for your time 🙏

[rstoenescu]

Fix will be available in "quasar" v1.9.9.