Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to allow fixing of lower electron-builder version #7106

Closed
customautosys opened this issue May 25, 2020 · 6 comments
Closed

Suggestion to allow fixing of lower electron-builder version #7106

customautosys opened this issue May 25, 2020 · 6 comments

Comments

@customautosys
Copy link
Contributor

Because of electron-userland/electron-builder#4629, I cannot build for Windows on Mac High Sierra if I use the latest electron-builder version. I have to use 21.2.0.

As a result, I had to manually edit the builder script file to stop it from installing the latest electron-builder.

I would like to suggest that the electron builder script perform a check if electron-builder is already installed, then install it only if it is not already installed. That way, we can use a lower version of electron-builder if it is necessary to circumvent bugs.

@rstoenescu
Copy link
Member

Hi,

What is the error being reported?
Just fixed a bug regarding electron-builder compatibility and wondering if this will also solve your problem.

@customautosys
Copy link
Contributor Author

The error being reported is an unidentified symbol __chkstk_darwin, this is a known issue in the latest electron-builder running on MacOS High Sierra (I would upgrade to Catalina but Apple says I can't install it) and the fix is to downgrade electron-builder to 21.2.0 which works perfectly.

I would like to suggest either of the following:

  1. Do not reinstall electron-builder if it is already installed (this would have the benefit of saving the user's time during a build as well); or
  2. Create an option to force the version of electron-builder to a particular version

@rstoenescu
Copy link
Member

  1. We can't have the major version of electron-builder or electron-packager not being checked. Because Quasar App CLI is the one using its API. Major version change might mean its programmatic usage might have changed -- and it happened twice since Electron mode was added. In the end this would result in a broken app, which is what we try to avoid.
  2. The electron-builder (or electron-packager) is first checked if it's installed and its major version matches what we know to be working (currently version "12"). Otherwise it doesn't gets installed. So saying "it always gets installed" is not correct. It is just an effect of you installing another major version of it.

Your scenario is an unfortunate one. However, I really recommend you to do something to keep the OS updated -- otherwise you might bump into other issues as well given the current pace at which Electron and the bundlers are evolving.

Regardless of everything, will add a way to skip the major version check (with a warning that it may simply not work due to their programmatic usage API changes). Pondering on the best way to do this in a future-proof manner. Will post updates here.

@customautosys
Copy link
Contributor Author

Thanks Razvan!

@rstoenescu
Copy link
Member

"@quasar/app-v1.9.5" will no longer force the version of electron-packager or electron-builder. However, when their programmatic usage will have a breaking change, we'll need to make a new release to support it.

@customautosys
Copy link
Contributor Author

FYI, this issue no longer exists. I just built a universal (Apple Silicon included) dmg using my High Sierra mac on electron-builder 22 and electron 12. So feel free to force the version of the electron-packager or electron-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants