Hidden q-drawer slows down scrolls on any element inside the app significantly #7317
Comments
HunderlineK
changed the title
HunderlineK
changed the title
|
Hello. |
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
|
Please do a small test form me: replace in package.json "quasar": "^1...." with "quasar": "https://github.com/pdanpdan/quasar#quasar-v1.12.8-test.2" and report here if it fixes the problem. Cleanup node_modules and yarn.lock / package-lock.json and do yarn/npm install. |
|
@pdanpdan Yes, I add this to my app.sass and it fixed the issue! I will try the other approach later after work and will let you know, thanks! |
|
@pdanpdan Trying to use the repository, it says: |
|
sorry, |
|
@pdanpdan I tried with the updated package; it doesn't fix the issue; however, I checked the layers and it doesn't show up as a potential slow down there; so 🤷♂️ 'display: none' definitely does work though. I still don't understand fully how Quasar components are implemented, otherwise I'd create a pull request to set Thanks for looking into it though; I'd say unless we can implement 'display: none' we can close the issue, since I don't have any evidence e.g. a recording to confirm 100% what's going on here. |
|
Please leave it open, we have to think of something to solve this. |
|
@pdanpdan Sure, thanks! Can't we set it to none only if the drawer is closed? |
|
No. I have to do some research |
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
|
Hi, can you please check again with |
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
|
@pdanpdan Just checked, it's fixed, thanks!! |
|
Thank you for checking :) |
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
|
Available in 1.12.9 |
…pen quasarframework#7317 - now that the TouchPan directive always emits the final event it should work as expected
Describe the bug
I have some overflowed divs which can be scrolled along the x axis. Scrolling by touch is smooth if I don't use q-drawer; however, it becomes janky once I add q-drawer.
Platform (please complete the following information):
Android: Chrome 83 on Android 10
I am not sure exactly how touch handler is working on q-drawer and why it slows down the scroll and if no-pointer-events still intercepts the touchs and just ignores them or what; however, looking at it differently, the issue is that the backdrop takes the whole screen in the first place even if drawer is closed.
Current behavior: drawer backdrop takes the whole screen even if drawer is closed and
no-swipe-backdropis set true (it seems currently it's just sent to back by modifying its z-index?)Expectd behavior: drawer backdrop should not be displayed (display: none) if drawer is closed and
no-swipe-backdropis enabled(I'd say since how big of a performance hit this is, probably in the next major revision
no-swipe-backdropshould be turned on by default if the performance can't be improved without removing the backdrop from display)The text was updated successfully, but these errors were encountered: