Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTime: Clicking last segment (minutes/seconds) doesn't trigger value emit if value is the same #8487

Closed
FrittenKeeZ opened this issue Feb 16, 2021 · 4 comments

Comments

@FrittenKeeZ
Copy link
Contributor

Describe the bug
If you have a time field with an existing value, you won't get a new value change if you try to select the same value.
Combined with QPopupProxy this causes the dialog to "hang" as if you didn't do anything.

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/dwarfhq/pen/YzpVKEB

To Reproduce
Steps to reproduce the behavior:

  1. Open any time picker
  2. Try to select the existing time
  3. See that the dialog remains
  4. Select a different time
  5. See that the dialog is closed

Expected behavior
Regardless of existing value, a value should be emitted when selecting the final component (minute/second).

Platform (please complete the following information):
Quasar Version: 1.15.3

@rstoenescu
Copy link
Member

This is not a bug.
All Quasar components don't do useless operations (such as emitting the same model as current one).

@pdanpdan
Copy link
Collaborator

It's not a bug in itself, but we should add a way to notify/emit when something is selected.

@FrittenKeeZ
Copy link
Contributor Author

@rstoenescu I understand what you mean, but I can assure you our client definitely see it as a bug, and I don't have a way of "fixing" it.

@rstoenescu rstoenescu reopened this Feb 18, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 20, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 20, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 23, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 28, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 28, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 4, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 8, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 10, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 11, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 14, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 15, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 16, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 16, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 18, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 18, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 18, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 16, 2022
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 18, 2022
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 5, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 8, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 10, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 15, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 16, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 19, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 7, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 15, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 1, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 9, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 21, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 21, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 31, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 4, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 27, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 4, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 5, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 12, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 4, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 8, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 21, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 21, 2023
…r kbd navigation; allow parsing partial date/time strings; do not reset min/sec when setting hour and sec when setting minute; update innerValue when using setNow before it's updated from external value quasarframework#12467, quasarframework#10727, quasarframework#8487, quasarframework#6306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants