Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QInput autofocus causes rendering issues in Chrome / Safari (not FireFox) #8533

Closed
dsl101 opened this issue Feb 24, 2021 · 5 comments
Closed

Comments

@dsl101
Copy link
Contributor

dsl101 commented Feb 24, 2021

Describe the bug
Using a QDialog to open a 'wizard' based on a QStepper, where each step contains a QInput, if the QInput is set to autofocus, the first step is not rendered properly on Chrome and Safari. Firefox appears to work correctly.

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/dsl101/full/OJbxBbQ
Note the issue appears to be related to viewport height, and so full-screen view is sometimes needed to reproduce the error on smaller monitors. Switching to Editor view will sometimes fix the issue when the window is not very tall. Likewise, changing the number of steps in the data section will affect whether or not the problem manifests.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the codepen in Chrome (windows or mac) or Safari (mac)
  2. Click on Show Popup
  3. The first step is rendered 'above' the top of the QDialog
  4. Typing some characters brings the QInput into view, but the behaviour is different on Chrome and Safari
  5. Change to a different step (e.g. Step 2), then close the dialog (Escape)
  6. Re-open the dialog, and all is correct.
  7. Go back to Step 1, close, reopen the dialog to see the error again.

Expected behavior
Step 1 would be rendered correctly

Screenshots
Initial state (incorrect):
image

After typing 'test', the QInput is shown, but the Step Title is not (on Chrome—on Safari, typing brings the Step Title into view as well):
image

After selecting Step 2, closing, reopening (now Step 1 is visible and selectable):
image

Platform (please complete the following information):
Quasar Version: 1.15.4
OS: Windows 10, macOS
Browsers: Chrome (88 & 90), Safari (14)

Additional context
Removing autofocus from the QInput seems to fix the rendering issue on all platforms / browsers.

pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 3, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 3, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 4, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 4, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 4, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 4, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 5, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 5, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 8, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 8, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 10, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 11, 2021
…opens and is focused; improve dialog scrolling on iOS; tweaks for QSelect quasarframework#8533

quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 16, 2022
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 18, 2022
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 5, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 8, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 10, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 15, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 16, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 19, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 7, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Feb 15, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 1, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 2, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 9, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 17, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 21, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 21, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 31, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 4, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Apr 27, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 4, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 5, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue May 12, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 4, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Sep 8, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 21, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 21, 2023
…nd is focused; improve dialog scrolling on iOS; tweaks for QSelect; add example of full page scroll dialog; improve animation on Android by using same border radius quasarframework#5351, quasarframework#8211, quasarframework#8380, quasarframework#8341, quasarframework#8533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants