Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPullToRefresh triggers when scrolling down, breaking scroll on children on touchscreens #9351

Closed
6 of 14 tasks
gnarrrl opened this issue May 20, 2021 · 1 comment
Closed
6 of 14 tasks

QPullToRefresh triggers when scrolling down, breaking scroll on children on touchscreens #9351

gnarrrl opened this issue May 20, 2021 · 1 comment
Labels
kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@gnarrrl
Copy link
Contributor

gnarrrl commented May 20, 2021

Describe the bug
Pull-to-refresh prevents scroll on children (e.g. q-list) because it can trigger regardless of pull direction.

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/bzens/pen/QWpdbXd?editors=1010

To Reproduce

  1. At y-scroll position 0
  2. Pull up on the list. No pull-to-refresh triggers.
  3. Pull down on the list. Pull-to-refresh triggers.
  4. Pull up on the list again. Now pull-to-refresh also triggers when scrolling up.
  5. On touchscreens, it is now impossible to scroll the list.

Expected behavior
Pull-to-refresh only triggering when pulling down at position 0, as seen in Material Guidelines - Swipe to Refresh

Platform (please complete the following information):
Quasar Version: 2.0.0-beta.17
@quasar/app Version: 3.0.0-beta.25
Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

OS: Windows 10 Home x86_64 10.19042
Node: 16.1.0
NPM: 7.11.2
Browsers: Chrome dev 90.0.4430.212
Android: 11
Electron: 12.0.9
@gnarrrl gnarrrl added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels May 20, 2021
rstoenescu added a commit that referenced this issue May 20, 2021
@gnarrrl @rstoenescu
fix: #9351 Prevent pull when scrolling up (#9352)
dc683f2 
* Prevent pull when scrolling up

* Update QPullToRefresh.js

Co-authored-by: Bernhard Zens <bernhard.zens@droconut.com>
Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
rstoenescu added a commit that referenced this issue May 20, 2021
@rstoenescu
fix(QPullToRefresh): prevent pull when not scrolling down #9351
10f9ab5
@rstoenescu
Copy link
Member

Thanks for reporting and contributing with a PR!
Will be available in v2.0.0-beta.18 and v1.15.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rstoenescu @gnarrrl