Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRouteTab [router-link] - event prop is deprecated and has been removed in Vue Router 4 #9642

Closed
2 tasks done
ttquoccuong opened this issue Jun 10, 2021 · 3 comments
Closed
2 tasks done

Comments

@ttquoccuong
Copy link
Contributor

ttquoccuong commented Jun 10, 2021

Describe the bug
A clear and concise description of what the bug is.

Codepen/jsFiddle/Codesandbox (required)
https://codesandbox.io/s/practical-curran-emwke?file=/src/layouts/MainLayout.vue

To Reproduce
Steps to reproduce the behavior:

  1. Create new Quasar App
  2. Add a QTabs with QRouteTab
    3.The Warning of VueRouter appear in console

Screenshots
Screen Shot 2021-06-11 at 00 13 32

Platform (please complete the following information):
Quasar Version: "^1.15.20",
@quasar/app Version: "^2.2.10",
Quasar mode:

  • SPA

Tested on:

  • SPA
@MilosPaunovic
Copy link
Member

MilosPaunovic commented Jun 10, 2021

Hello @ttquoccuong,

You are right, event prop is deprecated in Vue Router 4, as well as tag and addRoutes(), as it states in the official changelog and on the documentation for router-next.

But, the thing is that quasar/app currently uses "vue-router": "3.5.1", so those props and methods aren't deprecated in it.

Quasar v2 will utilise "vue-router": "4.0.8" from the start, so you don't have to worry about that, and if the router version gets updated to 4+ in this version of Quasar, be sure it will be implemented in the proper way.

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Jun 11, 2021

@ttquoccuong Could you close this issue if the above answers your questions?

@ttquoccuong
Copy link
Contributor Author

@MilosPaunovic yes, i know that.
one more thing, I think we should have a new label Warning which mean no bugs. I spend little minus to find it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants