Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTh component no longer propagates @click event #9864

Closed
2 of 14 tasks
Dylancyclone opened this issue Jun 29, 2021 · 1 comment
Closed
2 of 14 tasks

QTh component no longer propagates @click event #9864

Dylancyclone opened this issue Jun 29, 2021 · 1 comment
Labels

Comments

@Dylancyclone
Copy link

Describe the bug
The @click handler is not called when clicking on a QTh component

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/dylancyclone/pen/LYyEYEV

To Reproduce
Steps to reproduce the behavior:

  1. Create a QTh component
  2. Add a valid @click handler
  3. Click the QTh component
  4. Notice the click handler is not called

Expected behavior
The click handler should be called when the component is clicked like the QTd component, and as it did in Quasar v1 (example: https://codepen.io/dylancyclone/pen/ZEKYEEV)

Platform (please complete the following information):
Quasar Version: v2.0.1
@quasar/app Version: v3.0.1

Quasar mode:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

Tested on:

  • SPA
  • SSR
  • PWA
  • Electron
  • Cordova
  • Capacitor
  • BEX

OS: Ubuntu 20.04
Node: v12.22.1
Yarn: v1.22.10
Browsers: Chromium, Firefox

Additional context
Looking at the code, it appears the component only emits the click event if it's props say the column it's attached to is sortable

if (col.sortable === true) {
data.onClick = evt => {
props.props.sort(col) // eslint-disable-line
emit('click', evt)
}
}

@rstoenescu
Copy link
Member

Hi,

Thanks for reporting!
Fix will be available in Quasar v2.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants