feat(QBreadcrumbs): improvement for breadcrumb elements #11673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pdanpdan
commented
Dec 13, 2021
pdanpdan
commented
- add marker classes on breadcrumb el parent for when it's disabled/inactive or last
- don't apply activeClass on disabled breadcrumb els
- really disable last breadcrumb el (instead of using pointer-events)
- add visual indicator for active el when kbd navigating
- add marker classes on breadcrumb el for when it's disabled/inactive - don't apply activeClass on disabled breadcrumb els - leave the last breadcrumb enabled - add visual indicator for active el when kbd navigating
pdanpdan
force-pushed
the
feature/v1-breadcrumbs
branch
from
bc353e3
to
30b9ba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.