fix(docs): issues with searchbox on mobile #11686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stent with a "search"
…the page When this happens, you have to open the left drawer and do your search over again. This fix keeps the drawer open so user can then click a found item.
|
Tested with desktop and Google Pixel (as well as Chrome mobile emulation - refreshed on each one) |
|
From my POV you can remove all checks for desktop platform - if they have a keyboard with keys and escape on mobile all the best for the users |
|
That's true. I have a Samsung mini-tablet with a Bluetooth keyboard. I'll make the changes. |
|
Excellent. |
|
@hawkeye64 can you please port this for Q1 docs? |
|
@pdanpdan yes, but likely will have to do it tomorrow |
|
Actually, I have time and can do it now |
hawkeye64
added a commit
to hawkeye64/quasar
that referenced
this pull request
Dec 15, 2021
|
done: #11699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if you tap the "Enter" key on a mobile keyboard, after typing your search, the page gets reloaded. Right now, you can search, then tap off of the drawer to close it. This PR fixes this as well as using
type="search"so you get proper keyboard supports on mobile.