Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Added proper type for QForm submit event #12374

Merged
merged 2 commits into from
Feb 7, 2022
Merged

fix(types): Added proper type for QForm submit event #12374

merged 2 commits into from
Feb 7, 2022

Conversation

soulsam480
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@soulsam480
Copy link
Contributor Author

Currently the submit event emitted by QForm does pass the event object to the handler but it's not defined in the types. As VeeValidate depends upon the submit event for it's handleSubmit slot prop, it throws type error as the event is undefined.
image

@rstoenescu
Copy link
Member

Hi,

Thanks for contributing!
This will go into Quasar v2.5.4.

It breaks the build, but will fix it in a subsequent commit.

@rstoenescu rstoenescu merged commit a36af0b into quasarframework:dev Feb 7, 2022
@soulsam480
Copy link
Contributor Author

Thanks, I'm sorry for the build failure. I'm not 100% acquainted with the type generation system of quasar. Will try to look into it.

@rstoenescu
Copy link
Member

No problem. Thanks for PRing!

@soulsam480 soulsam480 deleted the fix/q-form-submit-event-type branch February 8, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants