Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QField/QSelect): improve attrs on controls #12383 #12485

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix(QField/QSelect): improve attrs on controls #12383 #12485

merged 1 commit into from
Mar 10, 2022

Conversation

pdanpdan
Copy link
Collaborator

#12383

  • QField: apply on external label if control slot is not present and if not QInput/QSelect
  • QSelect: apply on active element (target)

@pdanpdan
fix(QField/QSelect): improve attrs on controls quasarframework#12383
4987400 
quasarframework#12383

- QField: apply on external label if control slot is not present and if not QInput/QSelect
- QSelect: apply on active element (target)
@rstoenescu
Copy link
Member

Is there a PR for Qv2 also?

@pdanpdan
Copy link
Collaborator Author

pdanpdan commented Mar 8, 2022

Not yet, I have to check the code

@rstoenescu
Copy link
Member

I'd like to merge them both simultaneously, otherwise I'll forget about it for Qv2.

@rstoenescu rstoenescu merged commit f912cc0 into quasarframework:v1 Mar 10, 2022
@pdanpdan pdanpdan deleted the fix/v1-field-attrs branch March 10, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdanpdan @rstoenescu