Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for lang\ug.js #12537

Merged
merged 4 commits into from
Mar 7, 2022
Merged

changes for lang\ug.js #12537

merged 4 commits into from
Mar 7, 2022

Conversation

rider777
Copy link
Contributor

there are many wrongs in this language file . For example, translate "italic" to "Italian", “outdent” and "indent" is Increase the width and decrease the width, but I really don't know what this means by translation ,some of them are not translated . I've removed some unnecessary variable definitions. Also, I referred to the “UyghurSoft Dictionary”. In the end, I would like to thank @Ansar-786 , @Blfrg and all Quasar Framework teams for their selfless dedication.

there are many wrongs in this language file . For example,  translate "italic" to "Italian", “outdent” and "indent" is Increase the width and decrease the width, but I really don't know what this means by translation ,some of them are not translated . I've removed some unnecessary variable definitions. Also, I referred to the “UyghurSoft Dictionary”. In the end, I would like to thank @Ansar-786 , @Blfrg and all Quasar Framework teams for their selfless dedication.
@Blfrg
Copy link

Blfrg commented Feb 19, 2022

This is related to previous PR #7832 & [semi-resolved] issue #8123

Thank you @rider777 for taking the time to improve the generic Google translations with more accurate translations.
I verified the updated translations via Google (reverse translated) and they seem to convey the intended meanings.

LGTM 👍

ui/lang/ug.js Show resolved Hide resolved
Copy link
Contributor Author

@rider777 rider777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qdate

Copy link
Contributor Author

@rider777 rider777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that's completed.

@rider777 rider777 closed this Mar 5, 2022
@Blfrg
Copy link

Blfrg commented Mar 7, 2022

@rider777 thank you for making the requested changes.
However I don't think this will get merged since you closed the PR.

@pdanpdan please consider re-opening this and reviewing further.

@pdanpdan pdanpdan reopened this Mar 7, 2022
@rstoenescu rstoenescu merged commit 2a8eacc into quasarframework:dev Mar 7, 2022
@rstoenescu
Copy link
Member

Thanks for contributing!

@rstoenescu
Copy link
Member

This will go into Quasar v2.6.0 and v1.18.6

@rider777
Copy link
Contributor Author

rider777 commented Mar 16, 2022

This will go into Quasar v2.6.0 and v1.18.6

@rstoenescu @pdanpdan @Blfrg
Thanks for your support, I'm a new user of GitHub. I turned off pr by mistake before. Thank you to the quasar framework team for supporting our language. I love quasar, it's a great framework.

@rstoenescu
Copy link
Member

@rider777 cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants