Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-vite/app-webpack/utils/ui): add missing await for an async function call #12882

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

Hashen110
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@Hashen110 Hashen110 changed the title fix(app-vite): add missing await for an async function call fix(app-vite/app-webpack): add missing await for an async function call Mar 22, 2022
@Hashen110 Hashen110 changed the title fix(app-vite/app-webpack): add missing await for an async function call fix(app-vite/app-webpack/utils): add missing await for an async function call Mar 22, 2022
@Hashen110 Hashen110 changed the title fix(app-vite/app-webpack/utils): add missing await for an async function call fix(app-vite/app-webpack/utils/ui): add missing await for an async function call Mar 22, 2022
@rstoenescu rstoenescu merged commit fe97fa8 into quasarframework:dev Mar 22, 2022
@rstoenescu
Copy link
Member

Thanks for this!

@Hashen110 Hashen110 deleted the patch-1 branch May 4, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants