Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept file path as iconSet #12946

Merged
merged 2 commits into from
Mar 27, 2022
Merged

accept file path as iconSet #12946

merged 2 commits into from
Mar 27, 2022

Conversation

Mont4
Copy link
Contributor

@Mont4 Mont4 commented Mar 27, 2022

**What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

**Does this PR introduce a breaking change?

  • Yes
  • No

@rstoenescu
Copy link
Member

Hi,

Thanks for contributing!
Changed it a bit:

  1. Doesn't makes sense to duplicate so much code and also verify same things twice. So merged the branches.
  2. Same idea would apply to quasar/lang, so added it there too.

@rstoenescu rstoenescu merged commit 0295dbd into quasarframework:dev Mar 27, 2022
rstoenescu added a commit that referenced this pull request Mar 27, 2022
@rstoenescu
feat(app-vite;app-webpack): quasar.config.js > accept file path as ic…
f863988 
…onSet and lang (#12946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mont4 @rstoenescu