Fix getPackageJson problem for pnpm #13399
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pnpm
, the Quasar CLI with using functiongetPackageJson()
fails to resolvevite
package (to get version number from itspackage.json
file) because of howpnpm
structures thenode_modules
.The problem is in file
app-vite/lib/helpers/banner-global.js
. ThegetPackageJson()
function could not resolve thevite
package and returnedundefined
...This fix makes the resolver to look first in the specified directory and then in default paths instead of just in the specified directory. Then it works also with
pnpm
out of the box.The error:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: