Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-vite&app-webpack): Add <script setup> option for TS #13994

Merged
merged 4 commits into from Jul 20, 2022

Conversation

AnJ-Github
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

This PR introduces a new flag for quasar new command. New flag ts-composition-setup will generate components/layouts/pages with <script setup> syntax.

Documentation was also updated to match description provided within command line.

Options
    --help, -h            Displays this message

    --format -f <option>  (optional) Use a supported format for the template
                          Possible values:
                             * default - Default JS template
                             * ts-composition - TS composition API (default if using TS)
                             * ts-composition-setup - TS composition API with <script setup>
                             * ts-options - TS options API
                             * ts-class - [DEPRECATED] TS class style syntax
                             * ts - Plain TS template (for boot, store, and ssrmiddleware files)

Somewhat related to PR #13949

@AnJ-Github AnJ-Github marked this pull request as ready for review July 19, 2022 10:44
@yusufkandemir yusufkandemir self-requested a review July 19, 2022 10:47
@yusufkandemir yusufkandemir changed the title feat(app-vite&app-webpack): Add <script setup> option feat(app-vite&app-webpack): Add <script setup> option for TS Jul 20, 2022
@yusufkandemir yusufkandemir merged commit ab0cf86 into quasarframework:dev Jul 20, 2022
@yusufkandemir
Copy link
Member

Thanks for the contribution 👏 I think it would be nice if we offer script setup for non-TS projects as a separate format too. Feel free to implement it and open a PR 😉

@AnJ-Github AnJ-Github deleted the feat/new-option branch July 20, 2022 15:02
AnJ-Github added a commit to AnJ-Github/quasar that referenced this pull request Jul 20, 2022
…ramework#13994)

Co-authored-by: Andrzej <1andrzejkarbowski@gmail.com>
Co-authored-by: Yusuf Kandemir <yusuf.kandemir@outlook.com.tr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants