Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QCheckbox,QRadio,QToggle): set aria-hidden on the whole __inner content (includes visual style and form component) #13093 #14479

Merged
merged 1 commit into from
Sep 25, 2022
Merged

feat(QCheckbox,QRadio,QToggle): set aria-hidden on the whole __inner content (includes visual style and form component) #13093 #14479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/src/components/checkbox/QCheckbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ const bgNode = h('div', {
}, [
h('svg', {
class: 'q-checkbox__svg fit absolute-full',
viewBox: '0 0 24 24',
'aria-hidden': 'true'
viewBox: '0 0 24 24'
}, [
h('path', {
class: 'q-checkbox__truthy',
Expand Down
3 changes: 2 additions & 1 deletion ui/src/components/checkbox/use-checkbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ export default function (type, getInner) {
const child = [
h('div', {
class: innerClass.value,
style: sizeStyle.value
style: sizeStyle.value,
'aria-hidden': 'true'
}, inner)
]

Expand Down
6 changes: 3 additions & 3 deletions ui/src/components/radio/QRadio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ import { hSlot, hMergeSlot } from '../../utils/private/render.js'
const svg = h('svg', {
key: 'svg',
class: 'q-radio__bg absolute non-selectable',
viewBox: '0 0 24 24',
'aria-hidden': 'true'
viewBox: '0 0 24 24'
}, [
h('path', {
d: 'M12,22a10,10 0 0 1 -10,-10a10,10 0 0 1 10,-10a10,10 0 0 1 10,10a10,10 0 0 1 -10,10m0,-22a12,12 0 0 0 -12,12a12,12 0 0 0 12,12a12,12 0 0 0 12,-12a12,12 0 0 0 -12,-12'
Expand Down Expand Up @@ -161,7 +160,8 @@ export default createComponent({
const child = [
h('div', {
class: innerClass.value,
style: sizeStyle.value
style: sizeStyle.value,
'aria-hidden': 'true'
}, content)
]

Expand Down