Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): typescript declaration for humanStorageSize #17240

Merged

Conversation

marvin-wtt
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

Build Results

JSON API

📜 No changes detected.

Types

📜 Changes detected:

diff --git a/./current-build/types/utils/format.d.ts b/./pr-build/types/utils/format.d.ts
index 1587924..b2af289 100644
--- a/./current-build/types/utils/format.d.ts
+++ b/./pr-build/types/utils/format.d.ts
@@ -1,5 +1,5 @@
 export namespace format {
-  function humanStorageSize(size: number): string;
+  function humanStorageSize(bytes: number, decimals?: number): string;
   function capitalize(text: string): string;
   function between(v: number, min: number, max: number): number;
   function normalizeToInterval(v: number, min: number, max: number): number;

@rstoenescu rstoenescu merged commit 0cd5f34 into quasarframework:dev May 30, 2024
1 check passed
@rstoenescu
Copy link
Member

Thanks for contributing!

@marvin-wtt marvin-wtt deleted the fix-humanStorageSize-type branch May 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants