Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): adjust explanation of columns' name 馃枍 #4693

Merged
merged 2 commits into from Oct 26, 2019

Conversation

mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Jul 19, 2019

I had a really hard time understanding the difference between row-key which is often set to name in the examples here, and the name field on the columns object.

I know in retrospect it's a really simple difference: columns each have a name and rows each have an id or something to be set with row-key.

But I believe that the row-key has nothing to do with the columns name field if I'm not mistaken. So writing "used by row-key" at the columns name only further confused me. 馃槄

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I had a really hard time understanding the difference between `row-key` which is often set to `name` in the examples here, and the `name` field on the `columns` object.

I know in retrospect it's a really simple difference: columns each have a `name` and rows each have an id or something to be set with `row-key`.

But I believe that the `row-key` has nothing to do with the columns `name` field if I'm not mistaken. So writing "used by row-key" at the columns `name` only further confused me. 馃槄
@mesqueeb mesqueeb changed the title adjust explanation of columns' name 馃枍 fix(docs): adjust explanation of columns' name 馃枍 Jul 19, 2019
@rstoenescu rstoenescu merged commit 4e06227 into quasarframework:dev Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants