Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can set Spinner size using rem units #531

Merged
merged 1 commit into from
Apr 25, 2017
Merged

can set Spinner size using rem units #531

merged 1 commit into from
Apr 25, 2017

Conversation

bigzhu
Copy link

@bigzhu bigzhu commented Apr 25, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I set Spinner size using rem units, so maybe Spinner size need accept String type

@rstoenescu rstoenescu merged commit 3b73060 into quasarframework:v0.13 Apr 25, 2017
@rstoenescu
Copy link
Member

Merged. Thanks for this PR!

@rstoenescu
Copy link
Member

Available in edge v0.13 and future v0.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants