Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QTable): watch for changes when filter is an object #5356

Merged

Conversation

stefanvanherwijnen
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
Here is a demo of the problem:
https://codepen.io/stefanvh/pen/RwwoBWg

The changes in the filter object are not detected, thus a new request is never performed and the data is not filtered when using server-side filtering.

@rstoenescu
Copy link
Member

rstoenescu commented Oct 20, 2019

Hi,

Thanks for contributing!
But why would you not supply :filter="filter.name" directly to QTable?

@stefanvanherwijnen
Copy link
Contributor Author

stefanvanherwijnen commented Oct 21, 2019

Thanks.
I would like to filter 2 fields. E.g. filter = { name: '', surname: ''}. This is why filter needs to be an object.

I could also stringify and parse the object but I think it makes more sense to pass the actual object.

@rstoenescu rstoenescu merged commit 8d88042 into quasarframework:dev Oct 21, 2019
@rstoenescu
Copy link
Member

Ok. Will be available in "quasar" v1.2.5.
Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants