feat(ui,docs): Add back animation duration prop for QCarousel #4876 #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ramework#4876 **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [x] Documentation - [ ] Code style update - [ ] Refactor - [ ] Build-related changes - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [x ] No If yes, please describe the impact and migration path for existing applications: **The PR fulfills these requirements:** - [x] It's submitted to the `dev` branch and _not_ the `master` branch - [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix: #xxx[,#xxx]`, where "xxx" is the issue number) - [ ] It's been tested on a Cordova (iOS, Android) app - [ ] It's been tested on a Electron app - [x] Any necessary documentation has been added or updated [in the docs] If adding a **new feature**, the PR's description includes: - [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it) Add transition-duration property to all components that support transitions (QCarousel, QStepper, QTabPanel) allowing nested transitions to be viewed. Previously, when the first transition completed, subsequent animations were skipped showing the final state immediately. The transition-duration property defines an explicit time (in milliseconds) for the total animation. All transitions in this time are animated as intended. Examples requiring/using this commit have been included in the appropriate ui/dev pages. Documentation includes api description of transition-duration property and examples requiring/using the property on each of the transition supporting components. **Other information:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Add transition-duration property to all components that support transitions
(QCarousel, QStepper, QTabPanel) allowing nested transitions to be viewed.
Previously, when the first transition completed, subsequent animations were
skipped showing the final state immediately. The transition-duration property
defines an explicit time (in milliseconds) for the total animation. All
transitions in this time are animated as intended. Examples requiring/using
this commit have been included in the appropriate ui/dev pages.
Documentation includes api description of transition-duration property and
examples requiring/using the property on each of the transition supporting
components.
Other information: