Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support initial on fullscreen #549

Closed
wants to merge 1 commit into from
Closed

Conversation

pinghe
Copy link

@pinghe pinghe commented May 5, 2017

emit inFullscreen when change state of fullscreen

Signed-off-by: pinghe mzhx.meng@gmail.com

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

emit inFullscreen when change state of fullscreen

Signed-off-by: pinghe <mzhx.meng@gmail.com>
@pinghe
Copy link
Author

pinghe commented May 5, 2017

support initial on fullscreen
emit inFullscreen when change state of fullscreen

@rstoenescu
Copy link
Member

Hi, thanks for taking time for a PR! Have a few comments on this one though:

  • Following line cannot work because it will say "initfullscreen" is not defined: https://github.com/quasarframework/quasar/pull/549/files#diff-6b23faecf76ef12cb91496acfa206b7fL71
  • Same effect can be achieved if on the component using QSlider (probably a page, anyway doesn't matter) you put a mounted() { this.$refs.[refToSlider].toggleFullscreen() }. Since QSlider fullscreen tampers with window history (so it can be closed with back button) it's generally a bad idea to set fullscreen before mount point of QSlider as it can mess with page navigation in certain circumstances.

I'd be ok for adding a @fullscreen(bool) event though. Can you please reopen (or create new PR) with just the event addition?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants