Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #8292 (QBadge) add round prop #8370

Merged
merged 8 commits into from Jan 24, 2021
Merged

feat: #8292 (QBadge) add round prop #8370

merged 8 commits into from Jan 24, 2021

Conversation

suyundukov
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@pdanpdan
Copy link
Collaborator

#8292

ui/src/components/badge/QBadge.sass Outdated Show resolved Hide resolved
ui/src/components/badge/QBadge.styl Outdated Show resolved Hide resolved
Signed-off-by: Nurlan Su <dev@nurlan.co>
@rstoenescu rstoenescu merged commit dc7755b into quasarframework:dev Jan 24, 2021
@rstoenescu
Copy link
Member

Thanks for contributing!
Changed the "round" to "rounded" to match the syntax with other components as QBadge with this prop is not perfectly circle.

@rstoenescu
Copy link
Member

Nice work. A well done PR. Contains docs, examples, API.
I especially like the "1em" change which sealed the deal to merge it :)
Will be available in Quasar v1.15.2.

rstoenescu added a commit that referenced this pull request Jan 24, 2021
@suyundukov suyundukov deleted the feature/qbadge-round branch January 24, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants