Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app/ts): add types for App Extension APIs #9758

Merged
merged 4 commits into from
Jan 17, 2022
Merged

feat(app/ts): add types for App Extension APIs #9758

merged 4 commits into from
Jan 17, 2022

Conversation

stefanvanherwijnen
Copy link
Contributor

#8852

This time on the 'dev' branch.

@stefanvanherwijnen stefanvanherwijnen mentioned this pull request Jun 28, 2021
Open
@smadep
Copy link

smadep commented Nov 28, 2021

What's the status of this? Would really like to use "best-practice" http-auth with @stefanvanherwijnen 's extension

IlCallo
IlCallo requested changes Dec 31, 2021
View reviewed changes
app/lib/app-extension/Extension.js Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
app/types/app-extension.d.ts Outdated Show resolved Hide resolved
@IlCallo
Copy link
Member

IlCallo commented Dec 31, 2021

@stefanvanherwijnen sorry for the delay, I took a long trip to "AutomaticTestingLand" these months 😁
Many types can be greatly improved, but it's a really nice work even with what you did just now
Let me know if you plan to improve the types with my suggestions, or I can merge the PR and try to find some time to apply them myself

@stefanvanherwijnen
Copy link
Contributor Author

The actual types are indeed not very well defined 😁. I'll try to improve them next week now that I have some more experience with typescript and the AE API.

@stefanvanherwijnen
Copy link
Contributor Author

I updated the types. Let me know if there is anything else I need to change.

@IlCallo
Copy link
Member

IlCallo commented Jan 17, 2022

Really cool, if you have any time to check the { isClient: boolean, isServer: boolean} that would be really helpful :)

@IlCallo IlCallo changed the title feat(app): Add typescript support for app extensions feat(app/ts): add types for App Extension APIs Jan 17, 2022
@IlCallo IlCallo merged commit 04911d9 into quasarframework:dev Jan 17, 2022
@stefanvanherwijnen
Copy link
Contributor Author

Thanks 😄

@IlCallo
Copy link
Member

IlCallo commented Jan 17, 2022

Thanks to you for the contribution :)

@yusufkandemir yusufkandemir mentioned this pull request Jan 17, 2022
Closed
@IlCallo IlCallo mentioned this pull request Jan 18, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlCallo IlCallo IlCallo approved these changes

Assignees
No one assigned
Labels
area/typescript 🧑‍🤝‍🧑 team-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanvanherwijnen @smadep @IlCallo